Fix Freetube from crashing if caption attempting fallbacks to the FreeTube display language #5970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
|
Thank you for the pull request. Could you please pick a title that explains what the pull request actually does, as we use the titles as a basis for the changelogs and having the information in the title saves us a lot of time. |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 28, 2024
angus6b23
changed the title
ChunkyProgrammer
requested review from
PikachuEXE,
absidue,
ChunkyProgrammer and
kommunarr
absidue
approved these changes
Oct 28, 2024
kommunarr
approved these changes
Oct 28, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to Zeabyte/FreeTube-0
that referenced
this pull request
Oct 29, 2024
* development: (225 commits) Invidious API: Add support for auto-dubbed audio tracks (FreeTubeApp#5943) Fix settings password handling (FreeTubeApp#5988) Translated using Weblate (Serbian) Translated using Weblate (Breton) Translated using Weblate (Toki Pona) Translated using Weblate (Breton) Translated using Weblate (Toki Pona) Translated using Weblate (Icelandic) Bump youtubei.js from 10.5.0 to 11.0.0 (FreeTubeApp#5996) Bump shaka-player from 4.11.10 to 4.11.11 (FreeTubeApp#5995) Bump eslint-plugin-vue from 9.29.1 to 9.30.0 in the eslint group (FreeTubeApp#5994) Translated using Weblate (Latvian) Translated using Weblate (Toki Pona) Translated using Weblate (Icelandic) Translated using Weblate (Hungarian) Translated using Weblate (Toki Pona) Translated using Weblate (Icelandic) Translated using Weblate (Hungarian) Migrate FtListChannel and FtListHashtag to the composition API (FreeTubeApp#5945) Fix issue FreeTubeApp#5969 (FreeTubeApp#5970) ...
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix issue #5969
Pull Request Type
Related issue
closes #5969
Description
The crash seems to be an issue when Freetube tries to run the sortCaptions function. The function expect the "langauge" key as a string, but the getTranslatedLocaleCaption function sometimes return an object causing it to crash.
Screenshots
N/A
Testing
Tested with the link of issue #5969 with traditional chinese and other locale settings
Desktop
Additional context