Fix full window for videos with a 4:3 aspect ratio #5976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
kommunarr
approved these changes
Oct 27, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 28, 2024
ChunkyProgrammer
approved these changes
Oct 28, 2024
github-actions
bot
removed
the
PR: waiting for review
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix full window for videos with a 4:3 aspect ratio
Pull Request Type
Related issue
closes #5974
Description
For videos with a 4:3 aspect ratio we force the player container to be 16:9 and display black bars on the left and right side of the video instead of matching the aspect ratio of the video, to prevent the UI overflowing. As full window mode needs to be able to take up the entire window we have to remove the forced aspect ratio in that situation.
Screenshot and test case taken from the linked issue.
Screenshots
Testing
Desktop