Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply active FreeTube theme to shaka-player menus #5986

Merged
merged 2 commits into from
Nov 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,31 @@
flex-direction: column-reverse;
}

/*
Apply the active FreeTube base theme to shaka-player's menus.
Usually we go for classes and not element names,
however as we need to override shaka-player's CSS
we need to use the same selectors that they do.
*/

:deep(.shaka-overflow-menu),
:deep(.shaka-settings-menu) {
background: var(--card-bg-color) !important;
}

:deep(.shaka-overflow-menu button),
:deep(.shaka-settings-menu button) {
color: var(--primary-text-color) !important;
}

:deep(.shaka-overflow-menu button:hover),
:deep(.shaka-settings-menu button:hover) {
background: var(--side-nav-hover-color) !important;
color: var(--side-nav-hover-text-color) !important;
}

/* End of theming code */

.sixteenByNine {
aspect-ratio: 16 / 9;
}
Expand Down
4 changes: 4 additions & 0 deletions src/renderer/themes.css
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ it can be safely elided. This looks quite pleasant on this theme. */
text-decoration: underline;
}

.hotPink .shaka-range-container {
--primary-color: #fff;
}


/*************** DARK THEME ADJUSTMENTS ***************/

Expand Down