Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live streams buffering endlessly #6019

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Oct 29, 2024

Fix live streams buffering endlessly

Pull Request Type

  • Bugfix

Related issue

closes #5962

Description

This pull request fixes live stream playback breaking after a while, resulting in the player buffering endlessly.

Screenshots

debug-logs

Testing

Affects both backends for some users but in my case just Invidious, so I'm going to recommend testing with Invidious here.

  1. Set your preferred API backend to Invidious
  2. Open a lives stream e.g. lofi hip hop radio 📚 beats to relax/study to: https://youtu.be/jfKfPfyJRdk
  3. Check that playback works for more than a minute without endlessly buffering (showing the loading symbol)

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: c3c93d5

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 29, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 29, 2024 18:11
@absidue absidue changed the title Fix live streams endlessly buffering Fix live streams buffering endlessly Oct 29, 2024
@PikachuEXE
Copy link
Collaborator

I can't play any live stream on IV API (local is fine
Already tried all instances on https://api.invidious.io

image

@absidue
Copy link
Member Author

absidue commented Nov 3, 2024

@PikachuEXE Could you please try again, it probably just received some invalid data.

@PikachuEXE
Copy link
Collaborator

Same results
However I can play them on this IV instances (even loading takes quite long

@absidue
Copy link
Member Author

absidue commented Nov 7, 2024

It taking a long time is pretty much expected, as Invidious instances are currently quite overloaded and as we have to convert the URLs back to something shaka-player can actually use but Invidious then redirects us back to the original ones (if we use the original ones playback won't even start). The fix would have to happen on the Invidious side, either they remove the redirect and handle the URL as is or stop converting the URLs into something that shaka-player can't handle.

@PikachuEXE
Copy link
Collaborator

I still can't test (same error) for some reason with VPN on/off

@absidue
Copy link
Member Author

absidue commented Nov 10, 2024

@PikachuEXE Does the same issue happen for you on the development branch? If yes then it is not caused by this pull requests and considering that various users on the linked issue confirmed that it fixed the problem for them and they weren't getting transmuxing problems, I think it shouldn't be blocking for this pull request.

Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't access live stream in dev too
Just ship it

@FreeTubeBot FreeTubeBot merged commit 28e030c into FreeTubeApp:development Nov 11, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 11, 2024
@absidue absidue deleted the fix-live-playback branch November 11, 2024 06:35
Soham456 pushed a commit to Soham456/FreeTube that referenced this pull request Dec 5, 2024
SuperAKWA pushed a commit to SuperAKWA/FreeTube that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: viewing a live stream doesn't work well
5 participants