Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default locale to system #6031

Conversation

ChunkyProgrammer
Copy link
Member

Change default locale to system

Pull Request Type

  • Other - default setting update

Description

By default we should probably be using the language of the user's system if possible, otherwise we fallback to en-US. There were some issues with the system locale in the past which is why it wasn't made the default sooner but it seems to be working now.
I also updated the name of a variable to make it more clear that it's the fallback locale

Testing

  • Backup settings.db if you need it. (make sure to backup the dev one)
  • Delete the dev settings.db (make sure it's the dev one)
  • Go to settings > General Settings > Language preference
  • That setting should default to System default

Desktop

  • OS: Linux Mint
  • OS Version: 22
  • FreeTube version: 0.22.0

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 30, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 30, 2024 01:17
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely call this out as a significant change in the changelog, as English speaking users may have never changed the locale setting and might be surprised when FreeTube suddenly starts with their system locale instead.

@FreeTubeBot FreeTubeBot merged commit d84fda8 into FreeTubeApp:development Oct 31, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 31, 2024
Soham456 pushed a commit to Soham456/FreeTube that referenced this pull request Dec 5, 2024
SuperAKWA pushed a commit to SuperAKWA/FreeTube that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants