Add Play All and Shuffle Button #6153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
linked an issue
3 tasks
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: changes requested
and removed
PR: waiting for review
auto-merge was automatically disabled
November 15, 2024 11:48
Head branch was pushed to by a user without write access
|
I have fixed this error and I have hid the buttons when the playlist is empty. |
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Nov 15, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: waiting for review
|
I don't think the buttons should be shown in edit mode I will fix other buttons/inputs myself later |
auto-merge was automatically disabled
November 21, 2024 16:49
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Play All and Shuffle Button
Pull Request Type
Related issue
#5618
Description
Added
Play allandShufflebuttons to both user and youtube playlists.Clicking on
Play allalways plays the first video in the playlist.Clicking on
Shuffleplays a random video in the playlist and toggles shuffle mode on.Screenshots
Before
User Playlist
Youtube Playlist
After
User Playlist
Youtube Playlist
Testing
Play allplays the first video after video order is changed.Shuffleworks as intended after a video is deleted whilst playing through the playlist.Shuffleresets the playlist after adding a new video whilst it is playing its last item in the iteration. This behaviours is inherited from the development branch.Desktop
Additional context