-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Button to Show Original Title and Thumbnail for DeArrow #6164
base: development
Are you sure you want to change the base?
Conversation
Even though it feels kind of working for desktop |
I agree with @PikachuEXE here, maybe it would be better suited inside the dropdown? |
Didn't know it was available on mobile. What's the best way to test on mobile? |
@absidue I think putting it in the dropdown menu would make it too cumbersome to use this feature. |
If you don't want to move it to the dropdown where the rest of the options are then you'll have to stick with your current solution but undo the change to shrink the buttons. |
I think that we shouldn't put this in the dropdown and keep this as is. Some differences im seeing compared to #3900 (comment) title moves around on hover VirtualBoxVM_uhd6mYOPQa.mp4button has different sizes VirtualBoxVM_48KHtSzYNe.mp4 |
Head branch was pushed to by a user without write access
@efb4f5ff-1298-471a-8973-3d47447115dc I see the title also moving on hover in #3900 (comment)? About the button size, in the DeArrow extension there are two different button sizes. brave.mov |
I have changed back the button padding to its original size. Thinking of adding a new setting in the DeArrow setting to enable this toggle to see original title/thumbnail. |
I think https://fontawesome.com/icons/circle-dot?f=classic&s=solid is a better representation of the DeArrow button that is used on the YT side. Dot enabled color should be based on the secondary color theme firefox_s0pK2XtSBu.mp4Title moves around on hover VirtualBoxVM_GJQZKbc0BW.mp4Doenst hover here firefox_w2XRWfIjM2.mp4 |
Added Button to Show Original Title and Thumbnail for DeArrow
Pull Request Type
Related issue
closes #3900
Description
If DeArrow is enabled for title or/and thumbnail, when hovering over the video info area, a button is added next to the video title when the video is part of a list. This button switches the title or/and thumbnails back to its original version and vice versa.
Video
after.mov
Testing
Desktop
Additional context