Add icons to trending tab #6239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
absidue
approved these changes
Nov 28, 2024
PikachuEXE
approved these changes
Nov 29, 2024
kommunarr
approved these changes
Nov 29, 2024
github-actions
bot
removed
the
PR: waiting for review
There was a problem hiding this comment.
Not a dealbreaker but i do think that it would be better to change all the icon positions at the same when the space allows for it otherwise users can sometimes see the icons on top of the tab but on the tab to the next of it the icon is still beside next to the tab text
FreeTube_YeDX0ME0ob.mp4
This comment has been minimized.
This comment has been minimized.
3 tasks
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
jlvivero
pushed a commit
to jlvivero/FreeTube
that referenced
this pull request
Dec 7, 2024
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add icons to trending tab
Pull Request Type
Description
This PR adds icons to each of the trending tabs
Screenshots
Desktop