Add setting for opening URLs passed to FreeTube in a new window #6242
Conversation
github-actions
bot
added
the
PR: waiting for review
|
Are you talking about https://www.electronjs.org/docs/latest/tutorial/launch-app-from-url-in-another-app#overview ? Also I am not sure how/if the doc mentions deep links and if users understand what is |
Yes.
I agree, but I wasn't sure what else to name it. Do you have any suggestions? |
|
I found one place mentioning extensions but not sure how to call it It shouldn't be called "YouTube links" on the preference coz there are many "YT" links in video description/comment etc. Inviting more members to comment on this |
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
|
In Android land these are called "Intents" rather than "Links". But tbh I'd be sad if this feature is blocked on a label :D |
Pull request was converted to draft
github-actions
bot
removed
the
PR: waiting for review
github-actions
bot
added
the
PR: waiting for review
Head branch was pushed to by a user without write access
|
Sorry to bother @pakoito, didn't mean to request another review from you. |
static/locales/en-US.yaml
Outdated
| @@ -283,6 +283,7 @@ Settings: | |||
| Fallback to Non-Preferred Backend on Failure: Fallback to Non-Preferred Backend | |||
| on Failure | |||
| Enable Search Suggestions: Enable Search Suggestions | |||
| Open Links In New Window: Open freetube:// Links in a New Window | |||
There was a problem hiding this comment.
| Open Links In New Window: Open freetube:// Links in a New Window | |
| Open Links In New Window: Open URLs Passed to FreeTube in a New Window |
There was a problem hiding this comment.
or maybe "URLs Passed to FreeTube" as this setting also applies to links passed via the command line
There was a problem hiding this comment.
I have no objection to changing it to URLs Passed to FreeTube because that does sound clearer. If others think the messaging doesnt sound clear enough then maybe we should opt for implementing an tool tip message that explains what this does?
There was a problem hiding this comment.
Or just add tooltip giving examples of redirect extensions (mostly from those right?
Setting External Link Handling has one
|
could someone provide a build for me to test this one 😬 |
@efb4f5ff-1298-471a-8973-3d47447115dc https://github.com/OothecaPickle/FreeTube/actions/runs/12128622135 |
|
PR LGTM, only thing that should be looked at is the wording of the setting |
static/locales/en-US.yaml
Outdated
| @@ -283,6 +283,7 @@ Settings: | |||
| Fallback to Non-Preferred Backend on Failure: Fallback to Non-Preferred Backend | |||
| on Failure | |||
| Enable Search Suggestions: Enable Search Suggestions | |||
| Open Links In New Window: Open freetube:// Links in a New Window | |||
There was a problem hiding this comment.
Or just add tooltip giving examples of redirect extensions (mostly from those right?
Setting External Link Handling has one
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
|
You committed when I am about to comment on it lol |
OothecaPickle
changed the title
Head branch was pushed to by a user without write access
github-actions
bot
removed
the
PR: waiting for review
…TubeApp#6242) * open freetube:// links in new window * add setting for opening freetube:// links in new window * fix two windows being opened when link launches freetube * use multiple parameters instead of destructuring assignment * change setting name & add tooltip * minor correction * change tooltip wording
…TubeApp#6242) * open freetube:// links in new window * add setting for opening freetube:// links in new window * fix two windows being opened when link launches freetube * use multiple parameters instead of destructuring assignment * change setting name & add tooltip * minor correction * change tooltip wording
…TubeApp#6242) * open freetube:// links in new window * add setting for opening freetube:// links in new window * fix two windows being opened when link launches freetube * use multiple parameters instead of destructuring assignment * change setting name & add tooltip * minor correction * change tooltip wording
Add setting for opening URLs passed to FreeTube in a new window
Pull Request Type
Related issue
closes #1501
also relates to #6237
Description
Adds a toggle under General Settings to open
freetube://links in a new window rather than replacing the contents of an existing window.Screenshots
Testing
Test that
freetube://links opened from other applications are opened in a new window when the added setting is toggled on.Desktop
&
Additional context
I used some code from @pakoito's #5592.