Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hide Unsubscribe Button not hiding the button in search results #6298

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Fix Hide Unsubscribe Button not hiding the button in search results #6298

merged 1 commit into from
Dec 7, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Dec 7, 2024 •
edited
Loading

Fix Hide Unsubscribe Button not hiding the button in search results

Pull Request Type

  • Bugfix

Related issue

Description

This pull request fixes the Hide Unsubscribe Button in the Parental Control settings not affecting the channel tiles in search results.

Testing

  1. Turn on Hide Unsubscribe Button in the Parental Control settings
  2. Search for a channel e.g. Linus Tech Tips
  3. Check that channel tile in the search results doesn't have a subscribe or unsubscribe button.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 28f0b97

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 7, 2024 12:36
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 7, 2024
@FreeTubeBot FreeTubeBot merged commit 6e2ec28 into FreeTubeApp:development Dec 7, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 7, 2024
@absidue absidue deleted the unsubscribe-search-results branch December 7, 2024 14:03
jlvivero pushed a commit to jlvivero/FreeTube that referenced this pull request Dec 7, 2024
@absidue
Fix Hide Unsubscribe Button not hiding the button in search results (F…
d55efab 
…reeTubeApp#6298)
SuperAKWA pushed a commit to SuperAKWA/FreeTube that referenced this pull request Jan 24, 2025
@absidue
Fix Hide Unsubscribe Button not hiding the button in search results (F…
84e5a81 
…reeTubeApp#6298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@kommunarr kommunarr kommunarr approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc Awaiting requested review from efb4f5ff-1298-471a-8973-3d47447115dc

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Hide Unsubscribe Button does not hide button in search results
5 participants
@absidue @PikachuEXE @ChunkyProgrammer @kommunarr @FreeTubeBot