This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Adjust regex to be more resilient #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`title` was being used in the regex, but I forgot to escape it. The result was that titles with symbols which would normally be interpreted as Regex throw.
Added loop to check every video object for metadata until it finds one with something usable
MarmadileManteater
changed the title
|
Can u add Closes #116 in pr body? :) |
|
Oh thats my bad i meant #118 |
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE,
absidue and
ChunkyProgrammer
ChunkyProgrammer
approved these changes
Nov 2, 2022
absidue
approved these changes
Nov 2, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 2, 2022
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust regex to be more resilient
Pull Request Type
Related issue
Follow-up to #115
Closes #118
Description
I just realized that the regular expression used for finding channel names uses strings pulled from the YT response without sanitizing them first, and this will mean that any video with a symbol in the title could cause unexpected behavior. Vsauce is a really good example of this because they have lots of videos with weird symbols in the titles (EX: "mí͇͔̠śtk̥̞àẹ̶̢̪s "). I also added a loop to increase the likelihood that the channel name will be able to be successfully retrieved in channel page continuations.
If absolutely none of the videos in the continuation contain accessibility data which can be parsed, it still won't throw, but it will pass back the
channelNameas undefined. In FreeTube, this should just mean thechannelNamewon't display at all under the video which isn't the best thing in the world, but it is still better than simply throwing in the case of a catastrophic failure.Screenshots
before:
after: