Fixed saveDialog for firefox. #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bugvish, @jheising, @kcampbell or anyone from the freeboard team can review this issue please? |
|
I have a similar PR here. This is not only for Firefox but for all browsers. The |
|
@ThomasADavis Please, can you rename your PR title to remove “for firefox”? |
|
works for me |
|
Hello everybody, the fix works on Firefox and Safari. |
|
Hello, |
chrisv2
added a commit
to chrisv2/freeboard
that referenced
this pull request
Nov 7, 2018
joed74
added a commit
to joed74/freeboard-mqtt
that referenced
this pull request
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested this in firefox 40.0 under Linux, and it fixes the dialog problem I reported.