Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert integer type setting to integer #217

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

linsong
Copy link
Contributor

@linsong linsong commented Apr 19, 2017

AFAIU, there is only one integer type setting, that is Pane's 'Columns'. The columns value wil be used to calculate layout later by gridster plugin. If we don't convert the setting to integer, then it may cause undesired result later, considering plus a string number to a real number like this: '1' + 3 = '13', and then cause some layout issue.

Vincent Wang added 4 commits April 18, 2017 08:32
The data-sizex will be set directly by value of paneModel.col_width(),
and by default paneModel.col_width() is a number string, not number.
This will cause issues when gridster plugin trys to caclulate layout,
because for example 'string number'+'real number' will return a string
with two number string concated, not a number("1" + 3 = "13"), I think
this may cause some weird layout issue.
AFAIU, there is only one integer type setting, that is Pane's 'Columns'.
The columns value wil be used to calculate layout later by gridster
plugin. If we don't convert the setting to integer, then it may cause
undesired result later, considering plus a string number to a real
number like this: '1' + 3 = '13', and then cause some layout issue.
joed74 added a commit to joed74/freeboard-mqtt that referenced this pull request Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant