changed freeboardUI constructor and replaced constants with variables #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joed74
added a commit
to joed74/freeboard-mqtt
that referenced
this pull request
Aug 20, 2022
Added pull request Freeboard#227 Added highchart plugin from https://github.com/onlinux/freeboard-dynamic-highcharts-plugin, and added object-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I am using freeboard library to develop my own dashboard application. I overrode freeboard.js to change the freeboard behavior without changing its core, and keep the classes files as they are. But one there's one hindrance left: I need to be able to define those three parameters myself.
This allows pane_margin, pane_width and min_columns to be defined in freeboard.js while creating freeboardUI. It doesn't change much, but would help me and possibly others to carry out their own project based on freeboard.