Add sorting by project completion date #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreekBes
requested changes
Apr 18, 2023
like on Intra without the Improved Intra extension
depending on sort-projects-date setting
FreekBes
added a commit
to FreekBes/improved_intra_server
that referenced
this pull request
Apr 20, 2023
FreekBes
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new setting,
sort-projects-date, which can be toggled on to change the default sorting of grades on profiles from alphabetic ascending to completion date descending, putting the most recently completed projects at the top. Obviously this setting will need to be implemented on the backend before merging, because right now the wholeimprovedStorage.getblock on a nonexistent setting is never entered and so no sorting is done at all.