Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI config #375

Merged
merged 3 commits into from
Jun 26, 2022
Merged

Update CI config #375

merged 3 commits into from
Jun 26, 2022

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Jun 25, 2022

No description provided.

@ADmad
Copy link
Member Author

ADmad commented Jun 25, 2022

Ugghh.. The addition of id attribute to hidden inputs is causing a ton of test failures.

@ADmad ADmad force-pushed the ci branch 2 times, most recently from f1278b6 to f9d9f4e Compare June 25, 2022 20:43
@ndm2
Copy link
Collaborator

ndm2 commented Jun 25, 2022

Noice! Maybe we should add scheduled runs so that we get f'd in due time 😃

@ADmad
Copy link
Member Author

ADmad commented Jun 26, 2022

Also if we add the ids it will fail with prefer-lowest. Personally I wouldn't mind dropping that build.

@ndm2
Copy link
Collaborator

ndm2 commented Jun 26, 2022

We could either drop the build, or like with the ARIA changes, implement adding the ID in a backwards compatible manner into the form helper, until we can bump the CakePHP version.

@codecov
Copy link

codecov bot commented Jun 26, 2022

Codecov Report

Merging #375 (d787591) into master (32059df) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #375   +/-   ##
=========================================
  Coverage     99.23%   99.23%           
  Complexity      369      369           
=========================================
  Files            21       21           
  Lines          1046     1046           
=========================================
  Hits           1038     1038           
  Misses            8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32059df...d787591. Read the comment docs.

@ADmad
Copy link
Member Author

ADmad commented Jun 26, 2022

We could either drop the build, or like with the ARIA changes, implement adding the ID in a backwards compatible manner into the form helper, until we can bump the CakePHP version.

I have just ignored that failure for now.

@ADmad ADmad merged commit 4b60b2d into master Jun 26, 2022
@ADmad ADmad deleted the ci branch June 26, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants