Remove "Filter" from baked collections.

[ADmad]

Closes #315

[codecov]

Codecov Report

Merging #317 (22f8411) into master (1ef5fe9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #317   +/-   ##
=========================================
  Coverage     93.66%   93.66%           
  Complexity      224      224           
=========================================
  Files            19       19           
  Lines           616      616           
=========================================
  Hits            577      577           
  Misses           39       39           

Impacted Files	Coverage Δ
src/Command/Bake/FilterCollectionCommand.php	89.87% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef5fe9...22f8411. Read the comment docs.

[dereuromark]

OK
I would still like it if we used Filter suffix everywhere to make it more clear and searchable what those classes are for.

But since that would be a BC break now, I guess we have to go with this fix at this point.

Actually, my code works correctly with the prefix, maybe docs should be adjusted instead?

[dereuromark]

Ah, because of this one it works:

$this->Videos->addBehavior('Search.Search', [
	'collectionClass' => VideosFilterCollection::class,
]);

[ADmad]

Ah, you are setting the collection class as default one. Without that it would also require one to specify the collection as foo_filter instead of just foo in the find call.

So it's best to remove "Filter" avoid confusion for users.

[dereuromark]

Sure, I would just like to revisit this for a new major then.