perf: only load user state when showing full user data #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davwheat
approved these changes
Mar 8, 2024
imorland
approved these changes
May 20, 2024
imorland
added a commit
that referenced
this pull request
Jun 16, 2024
|
@SychO9 I've reverted this change for now due to https://discuss.flarum.org/d/11714-fof-terms-ask-your-users-to-accept-tos-and-privacy-policy/177 Could you please take a look at this and submit a new PR when possible? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fof terms only needs the serialized state for the modal to see if a user accepted, this can be optimized by lazy loading the full user data from the modal.
The other attributes are only needed for the current user serialization.
This prevents unnecessary querying of the terms state when serializing discussion & post authors in other endpoints. Solves a massive slowdown with big data.