Merge pull request #218 from mlocati/install-return-code

Exit with non-zero when pecl install fails
FriendsOfPHP · Jan 25, 2021 · dee49ac · dee49ac
2 parents 6ee26d7 + a651036
commit dee49ac
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/Console/Command/InstallerCommand.php b/src/Console/Command/InstallerCommand.php
@@ -167,7 +167,7 @@ protected function binaryInstallWindows($path, InputInterface $input, OutputInte
     }
 
     /*  The most of this needs to be incapsulated into an extra Build class*/
-    protected function sourceInstall($package, InputInterface $input, OutputInterface $output, $optionsValue = [], $force_opts = '')
+    protected function sourceInstall($package, InputInterface $input, OutputInterface $output, $optionsValue = [], $force_opts = ''): bool
     {
         $helper = $this->getHelperSet()->get('question');
 
@@ -181,6 +181,7 @@ protected function sourceInstall($package, InputInterface $input, OutputInterfac
             $build->install();
 
             $this->saveBuildLogs($input, $build);
+            $result = true;
         } catch (Exception $e) {
             $this->saveBuildLogs($input, $build);
 
@@ -189,8 +190,11 @@ protected function sourceInstall($package, InputInterface $input, OutputInterfac
             if ($helper->ask($input, $output, $prompt)) {
                 $output->write($build->getLog());
             }
+            $result = false;
         }
         $build->cleanup();
+
+        return $result;
     }
 
     protected function execute(InputInterface $input, OutputInterface $output)
@@ -217,9 +221,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             return 0;
         }
 
-        $this->sourceInstall($package, $input, $output, $optionsValue, $force_opts);
-
-        return 0;
+        return $this->sourceInstall($package, $input, $output, $optionsValue, $force_opts) ? 0 : 1;
     }
 }