Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP coding style rules and check PHP coding style #211

Merged
merged 5 commits into from
Jan 25, 2021

Conversation

mlocati
Copy link
Collaborator

@mlocati mlocati commented Jan 18, 2021

No description provided.

@pierrejoye
Copy link
Member

It seems 7.2 is failing here too

@mlocati
Copy link
Collaborator Author

mlocati commented Jan 24, 2021

It seems 7.2 is failing here too

Tests have been fixed by #213, so rebasing this PR should fix that failure. But of course since this PR doesn't include the fixes of the coding style rules, the "Check coding style" fails.
Before applying the rules, we'd need to decide if the rules I propose here are ok for you.

For example, I have a question: having a very long license related comment at the beginning of every PHP file makes the code a bit harder to be read (example).
So, what about replacing it with something like this?

/*
 * This file is part of the Pickle project.
 * @license https://github.com/FriendsOfPHP/pickle/blob/master/LICENSE
 */

@mlocati
Copy link
Collaborator Author

mlocati commented Jan 24, 2021

PS: you can see the changes that would fix the proposed rules by seeing the output of the "Check coding style" step (this one at the moment).

@mlocati mlocati merged commit 6ee26d7 into FriendsOfPHP:master Jan 25, 2021
@mlocati mlocati deleted the cs branch January 25, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants