support bundle alias notation #1566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // the base class is only available since symfony 2.3 | ||
| $symfonyVersion = class_exists('Symfony\Bridge\Doctrine\DependencyInjection\CompilerPass\RegisterMappingsPass'); | ||
| // alias support was added later | ||
| $symfonyVersion = version_compare(Kernel::VERSION, '2.6.0', '>='); |
There was a problem hiding this comment.
if we have symfony 2.6 but DoctrineBundle < 1.3 the alias support will still not work. but i don't think its worth starting to introspect the orm compiler pass and whatnot.
or we could simply never use the compiler pass from symfony but always our local compiler pass...
|
given that there is no entity in FOSUserBundle but only mapped superclasses, is it really worth it ? there is no reason to reference a mapped superclass anywhere in Doctrine, except for extending it (and this does not use Doctrine aliases...) |
|
ah, i thought its theoretically possible to use the models directly. indeed they are abstract classes - that also explains why nobody had a problem with us not providing the alias. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement symfony/symfony#10853 so that
FOSUserBundle:Userworks again.I guess this is a rare case, as people will extend the user class and then have doctrine do the alias for their extending class. But for consistency, it makes sense to do this.