add(test) enable phpunit tests

[connorhu]

and its done.

PR adds phpunit. Unit tests are removed at last and then I will add the finished work bit by bit. I decided to do this because the work was becoming unmanageably large. I know why I did what I did, but for you to see through and approve it, it's easier to go component by component.

this depends on #325

[thePanz]

@connorhu would you extract the removal of the Version tag into its own PR?
This way we can have a more focused (and reduced) changeset 👍

[connorhu]

@connorhu would you extract the removal of the Version tag into its own PR? This way we can have a more focused (and reduced) changeset 👍

Sorry, I don't know how it got there.

[connorhu]

php-cs-fixer 403: rate limit exceeded ☹️

[connorhu]

I studied some how-tos and changed my mind. For phpunit testing we will also prefer phar based installs. The composer/script section shows which version is preferred. This can be expanded later if we want to support higher phpunit versions. For now I don't see the sense in this, version 9 will be fine.

[thePanz]

I studied some how-tos and changed my mind. For phpunit testing we will also prefer phar based installs. The composer/script section shows which version is preferred. This can be expanded later if we want to support higher phpunit versions. For now I don't see the sense in this, version 9 will be fine.

I would suggest to use phive to install the phar files. We could just ship the '.phive/phive.xml' file in the repo, where versioning is done there.

Drawback: the phive will run the installation without checking the currently installed PHP version, we would need to tale some extra care of the versioning, or have 2 phive.xml for php7 and php8

Wdyt?

[connorhu]

I would suggest to use phive to install the phar files. We could just ship the '.phive/phive.xml' file in the repo, where versioning is done there.

Drawback: the phive will run the installation without checking the currently installed PHP version, we would need to tale some extra care of the versioning, or have 2 phive.xml for php7 and php8

Wdyt?

I'm going to dig into this and figure out what we can do here with phive.

[connorhu]

I have some concerns about this tool. It can do some things but it's a bit awkward to use.

• phars xml undocumented, no xsd
• writes the installed version into the config and you can't make it not do that
• you need a phars.dist.xml file which has no exact version. for us it's enough to say that we need phpunit ^9.6, the detailed version is not interesting
• you can't set an alternative configuration file for it

We can live with these gaps, but it's a bit meh.