-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QA] added phpstan dist config #312
Draft
connorhu
wants to merge
18
commits into
FriendsOfSymfony1:master
Choose a base branch
from
connorhu:feature/stanconfig
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2964ac3
add(QA) phpstan dist config
connorhu fb6f499
switch back to level 1
connorhu d17b7ca
added more excludes
connorhu 19d6aac
added php version
connorhu 9839a42
renamed neon file
connorhu 5c9b812
added baseline
connorhu 986fc7a
updated baseline
connorhu 649a5ed
added doctrine1 to dev deps
connorhu b606a53
added lib/plugins/sfDoctrinePlugin/test/ to exclude
connorhu fa27a9d
added tmpDir: .cache/phpstan
connorhu 19ccfa3
added gha config
connorhu c4c7960
lock version and fix path
connorhu 356ac97
removed test folder
connorhu d69d0b4
updated baseline
connorhu 7d79c30
added pear includes, updated baseline
connorhu ff6fc0e
starting at level 0
connorhu 7cc334d
updated baseline
connorhu 8fcb184
added req version to doctrine1
connorhu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| name: Static Analysis | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - master | ||
| paths: | ||
| - .github/workflows/static-analysis.yml | ||
| - tests/StaticAnalysis/* | ||
| - composer.* | ||
| - lib/** | ||
| - phpstan* | ||
|
|
||
| push: | ||
| branches: | ||
| - master | ||
| paths: | ||
| - .github/workflows/static-analysis.yml | ||
| - tests/StaticAnalysis/* | ||
| - composer.* | ||
| - lib/** | ||
| - phpstan* | ||
|
|
||
| jobs: | ||
| static-analysis-phpstan: | ||
| name: Static Analysis with PHPStan | ||
| runs-on: ubuntu-22.04 | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| coverage: none | ||
| php-version: 7.4 | ||
| tools: cs2pr, phpstan:1.10.63 | ||
|
|
||
| - name: Install dependencies with Composer | ||
| uses: ramsey/composer-install@v2 | ||
|
|
||
| - name: Run static analysis | ||
| run: phpstan analyse --error-format=checkstyle | cs2pr |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,3 +8,4 @@ | |
| lib/plugins/sfDoctrinePlugin/test/functional/fixtures/log/ | ||
| /vendor | ||
| /composer.lock | ||
| phpstan.neon | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <?php | ||
|
|
||
| class ProjectConfiguration extends sfProjectConfiguration | ||
| { | ||
| } | ||
|
|
||
| class BaseForm extends sfForm | ||
| { | ||
| } | ||
|
|
||
| include 'PEAR/REST/10.php'; | ||
| include 'PEAR/REST/11.php'; | ||
| include 'PEAR/Frontend/CLI.php'; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 why do we need PEAR?! 🙈
Should we completely drop it? @thirsch IIRC you mentioned something like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugin uses this. i would drop it too as you can see in my plugin loading improvement issue #342 . if only because the default symfony channels don't work. refer to propel discussion