-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] introduce mode: experimental
flag
#335
base: master
Are you sure you want to change the base?
[ci] introduce mode: experimental
flag
#335
Conversation
9032740
to
456ee6d
Compare
mode: experimental
flag
6aa83bb
to
e7fcce1
Compare
If this works, we can roll out the solution to other repos and start testing it with php 8.4. |
@@ -59,4 +59,14 @@ jobs: | |||
run: php data/bin/check_configuration.php | |||
|
|||
- name: Run Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would continue-on-error
work here as well? Maybe with something like
- name: Run Tests
run: ...
continue-on-error: ${{ matrix.mode == "experimental"}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is possible that it works. Why didn't I find it in the documentation when I searched?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the continue-on-error
will only make sure the other PHP versions still run and not abort as soon as one fails. But if one fails, the CI will still be marked as failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's true! The status is also important here to keep the result green.
IMHO, I'm not sure this hack is worth the time and added complexity, given that a) php8.4 is at least 8 months away from .0 release (why test something that may still change?) and b) our tests are already passing with php8.4 anyway. |
I think in our case (seeing our reaction time) it is very important to foresee what the new version will bring (and run tests with that version). I'm not sure if it's worth it to make it switchable either, but in the end it's not a big change (I'd rather test it with phpunit). |
e7fcce1
to
5b0e526
Compare
Like a feature flagThe overall test suite should pass when the feature flag is enabled or disabled. Regarding this principle, a failed test should always fail the job. But how to progressively make symfony1 compatible with next PHP version?Test case after test case.
With this plan, each contributor can provide a small PR with one test file executed on the next PHP version. |
@thePanz This was the best solution I found. If
mode: experimental
is enabled, the exit status is printed but exits the shell with a zero.This changes is because of php8.4 testing. We can now mark php version as experimental.