Decent implementation of Klipper_led_effects and rainbow barf lets #412

claudioguareschi · 2023-12-20T02:49:42Z

I took the liberty to modify your excellent klipain to add support for led_effects and rainbow barf.
Led_effects can be set separately for caseligts, plain sb status leds/rainbow barf in any combination.
Respecting yout phylosophy configuration is done in printer.cfg
Few files were created in config/hardware/lights to support rainbow barf and led effects.
Logic in mcros/hardware_functions/status_leds.cfg was adapted to support led effects, attempting to respect the existing code as much as possible.
Leveling and meshing functions were modified to support led status changes when run from mainsail/fluidd

I played with the effects a little bit, tested using plain sb 3 led setup (I have a barf coming soon). The effects I choose respecting the existing default colors as much as possible are ok for now but need to be refined to make the final setup look really good. Creating the right default effects is a work in progress.

Hope this is useful. Let me know what you think

Claudio

Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>

Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com> Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

…Frix-x#406) Fix issue discovered after merging Frix-x#380

Surion79 · 2023-12-20T05:47:56Z

that looks pretty nice on first flythrough :)

Benoitone · 2023-12-20T09:29:47Z

I'm very interested to add this future too for the next ERCF 🤩

Surion79 · 2023-12-20T11:52:02Z

macros/hardware_functions/status_leds.cfg

+            _SET_LEDS_BY_NAME LEDS="nozzle" COLOR={status_color[color].nozzle} TRANSMIT=1
+        {% elif printer["gcode_macro _USER_VARIABLES"].status_leds_logo_led_name == "status_leds_effects"%}
+            {% set print_line = "Effect changed - logo: %s, nozzle: %s\n" % ("sb_logo_" + status_color[color].logo, "sb_nozzle_" + status_color[color].nozzle) %}
+            {action_respond_info(print_line)}


is this needed? looks like some sort of info printing of the print?

(i mean line 188)

No I wouldn't have it on the finished implementation. It is there more for debug purposes and to make sure effects are triggered when they are supposed to. For example QGL effect wasn't working for me and printing out this info allowed me to find a reset to the ready state in conditional homing (_CG28 macro) outside its if condition that was messing things up. It was making the regular status led flicker and totally messing up the effects. This implementation is not completed yet. I just submitted to see if you guys were interested in me continuing pursuing this avenue, as I saw other people already attempting to integrate led effects into klippain.

Yes, I'm all in for this PR 🚀
Thanks a lot for your work!

user_templates/printer.cfg

Frix-x

Ok thank you very much for this big PR. I'm really happy about it and it's already pretty good.
I've made some comments to make it a little bit better on the user side.

Also some more comments here:

Please rename all "rb" references in the filenames, etc... to something more easy to understand like "rainbowbarf" or at least "rbarf"
You've made some change about the placement of the STATUS_LED call in the submacros. This is pretty good and a work that has already started with Fixed status leds for meshing aand nozzle cleaning #404 . But I'll close Fixed status leds for meshing aand nozzle cleaning #404 in favor of your PR that is more complete. In order to clean up a little bit and prepare for a future merge, can you remove the comments you've left at the previous places?

user_templates/printer.cfg

macros/miscs/startup.cfg

Frix-x · 2023-12-20T13:50:51Z

macros/hardware_functions/status_leds.cfg

+            _SET_LEDS_BY_NAME LEDS="nozzle" COLOR={status_color[color].nozzle} TRANSMIT=1
+        {% elif printer["gcode_macro _USER_VARIABLES"].status_leds_logo_led_name == "status_leds_effects"%}
+            {% set print_line = "Effect changed - logo: %s, nozzle: %s\n" % ("sb_logo_" + status_color[color].logo, "sb_nozzle_" + status_color[color].nozzle) %}
+            {action_respond_info(print_line)}


Yes, I'm all in for this PR 🚀
Thanks a lot for your work!

Surion79 · 2023-12-20T14:29:49Z

i really like the quality of the PR. It is indeed decent and thought through.

claudioguareschi · 2023-12-20T15:30:51Z

Be glad to make all the proposed fixes. Easily done.
I would love for somebody with a better aesthetic sense than I have to help out with some thought out effects that make the printer look good without making it look like a flying saucer!
A couple of questions:
Should we consider additional printer states for heater bed soaking and/or ercf functions?

Surion79 · 2023-12-20T15:46:43Z

A couple of questions: Should we consider additional printer states for heater bed soaking and/or ercf functions?

Regarding ERCF/HH, Benetoine is currently integrating an updated version. So I think for now, we should go forward with this
Regarding additional printer states: It is important to understand, when which lights are triggered. If someone is not careful, the status might result in strobe flashes (because there is nothing done between two led status calls, thats why _CG28 got changed recently)

Frix-x · 2023-12-20T16:29:06Z

Should we consider additional printer states for heater bed soaking and/or ercf functions?

I think this is not needed for now. We can keep it like this since all the previous state are correctly managed.

On the ERCF topic, there is a big ERCF PR (#371) ongoing to get compatibility with the ERCFv2 and the latest HH software. So I think the ERCF states could be managed directly in this PR when your PR is merged. Feel free to participate to it if you want :)

Surion79 · 2023-12-20T22:44:52Z

@Frix-x the base must be changed to develop in this PR. since a lot of effort is done already, i cannot grasp possible issues on rebase to develop. currently it is pointing to main

Benoitone · 2023-12-20T22:45:58Z

Should we consider additional printer states for heater bed soaking and/or ercf functions?

I think this is not needed for now. We can keep it like this since all the previous state are correctly managed.

On the ERCF topic, there is a big ERCF PR (#371) ongoing to get compatibility with the ERCFv2 and the latest HH software. So I think the ERCF states could be managed directly in this PR when your PR is merged. Feel free to participate to it if you want :)

For the MMU/ERCF klipper_led seems to be natively supported by Happy_Hare... I haven't been able to test it yet... I am in the process of assembling my ERCFv2...
But this PR interests me a lot for the management of the other LEDs and to see how it behaves.
I would be in favor of pushing it on a new branch of klippain before its merge when @Frix-x wishes. So that I can see what it could give in parallel with the management of Happy_Hare.

Benoitone · 2023-12-20T22:52:10Z

As an off topic, I still have a problem with LED flashing at the time of the QGL in _MODULE_TILTING I think there is something to check on this side...

Surion79 · 2023-12-20T23:15:36Z

Should we consider additional printer states for heater bed soaking and/or ercf functions?

I think this is not needed for now. We can keep it like this since all the previous state are correctly managed.
On the ERCF topic, there is a big ERCF PR (#371) ongoing to get compatibility with the ERCFv2 and the latest HH software. So I think the ERCF states could be managed directly in this PR when your PR is merged. Feel free to participate to it if you want :)

For the MMU/ERCF klipper_led seems to be natively supported by Happy_Hare... I haven't been able to test it yet... I am in the process of assembling my ERCFv2... But this PR interests me a lot for the management of the other LEDs and to see how it behaves. I would be in favor of pushing it on a new branch of klippain before its merge when @Frix-x wishes. So that I can see what it could give in parallel with the management of Happy_Hare.

i suggest to complete the big HH-PR first before sidetracking it for another feature, IMHO. Ex manager had a saying: better metal on the road than gold in the storage (meaning software)

Surion79 · 2023-12-20T23:17:28Z

As an off topic, I still have a problem with LED flashing at the time of the QGL in _MODULE_TILTING I think there is something to check on this side...

at some point, it might need to be required to use params to differ between mainsail call and call within a process (like start_print) to correctly set the leds in manual use and automated/integrated use. I had the thought already couple time when looking at the strobe flashing issue.

Frix-x · 2023-12-21T10:01:57Z

Ok so I indeed changed the target to develop and will do a final review soon but it look like ok for me on a first sight now :)

…arf_effects.cfg

Frix-x · 2023-12-21T10:06:16Z

Mhmm I think the automated target change directly on Github was not a good idea after this number of commit and I should have done it manually... I'll fix it.

) Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

tehniemer and others added 8 commits December 13, 2023 10:34

Turn on filter only if it was used during printing. (Frix-x#380)

c67fa94

Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com>

added parameters to park (Frix-x#391)

843a08c

M8P v2.0 SPI fix (Frix-x#389)

bbd8e0f

Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

Add per material filament sensor management (Frix-x#381)

cba4647

Remove _TIP_SHAPING from End/cancel print macros (Frix-x#357)

f8b817a

Co-authored-by: Jan-Gerrit Drexhage <102791900+Surion79@users.noreply.github.com> Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

Klipper SET_PRINT_STATS_INFO compatibility (Frix-x#392)

a8f516d

Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

Fix error with turning on filter only if it was used during printing. (…

1793847

…Frix-x#406) Fix issue discovered after merging Frix-x#380

fix missing variable to cancel_print (Frix-x#408)

e1a6cba

Surion79 reviewed Dec 20, 2023

View reviewed changes

user_templates/printer.cfg Outdated Show resolved Hide resolved

Frix-x requested changes Dec 20, 2023

View reviewed changes

Frix-x mentioned this pull request Dec 20, 2023

Fixed status leds for meshing aand nozzle cleaning #404

Closed

filament sensor status checks universal (Frix-x#411)

09c40f3

Frix-x added the enhancement New feature or request label Dec 20, 2023

Frix-x changed the base branch from main to develop December 21, 2023 10:00

Frix-x added next version This thing is already done or is planned in the next version in preparation tracking This issue is tracked and work will be done labels Dec 21, 2023

Fysetc Catalyst Config

a5e5599

Claudio Guareschi and others added 23 commits December 21, 2023 11:02

fixed effect

46130f4

fixed effect

5b3cc42

Caselights effects done

91671db

Caselights effects done

6e83fcf

Restored github repository to frix-x

ec6b152

Fyxed a typo

77ba2d6

For review

4205d9d

Update tilting.cfg to remove comments

ab7ef38

Update and rename status_leds_rb_effects.cfg to status_leds_rainbow_b…

2004adf

…arf_effects.cfg

Changes requested

d82a32f

changed github repo to my fork for testing

e0bd654

Fixed effect on startup process end

42a2995

Added done printing

f225627

Printing effect

680bfdc

effects effects...

8a72c50

done printing strobe effect

6b6ccdd

testing effects

f269212

syntaz

9b20178

fixed brain fart

3b13e85

fixed effect

9ca61ab

fixed strobe timing

19980ff

fixed effects

057a2b7

fixed typo on barf

5db7c1b

Frix-x force-pushed the main branch from 7b16707 to 5db7c1b Compare December 21, 2023 10:02

Frix-x changed the base branch from develop to leds-rework December 21, 2023 10:07

Merge branch 'leds-rework' into main

252d44e

Frix-x self-assigned this Dec 21, 2023

Frix-x merged commit dfc0fc1 into Frix-x:leds-rework Dec 21, 2023

Frix-x added a commit that referenced this pull request Dec 21, 2023

Decent implementation of Klipper_led_effects and rainbow barf lets (#412

22c6ea9

) Co-authored-by: Félix Boisselier <felix@fboisselier.fr>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Decent implementation of Klipper_led_effects and rainbow barf lets #412

Decent implementation of Klipper_led_effects and rainbow barf lets #412

claudioguareschi commented Dec 20, 2023

Surion79 commented Dec 20, 2023

Benoitone commented Dec 20, 2023

Surion79 Dec 20, 2023

Surion79 Dec 20, 2023

claudioguareschi Dec 20, 2023

Frix-x Dec 20, 2023

Frix-x left a comment

Frix-x Dec 20, 2023

Surion79 commented Dec 20, 2023

claudioguareschi commented Dec 20, 2023

Surion79 commented Dec 20, 2023

Frix-x commented Dec 20, 2023

Surion79 commented Dec 20, 2023

Benoitone commented Dec 20, 2023

Benoitone commented Dec 20, 2023

Surion79 commented Dec 20, 2023 •

edited

Loading

Surion79 commented Dec 20, 2023

Frix-x commented Dec 21, 2023

Frix-x commented Dec 21, 2023

Decent implementation of Klipper_led_effects and rainbow barf lets #412

Decent implementation of Klipper_led_effects and rainbow barf lets #412

Conversation

claudioguareschi commented Dec 20, 2023

Surion79 commented Dec 20, 2023

Benoitone commented Dec 20, 2023

Surion79 Dec 20, 2023

Choose a reason for hiding this comment

Surion79 Dec 20, 2023

Choose a reason for hiding this comment

claudioguareschi Dec 20, 2023

Choose a reason for hiding this comment

Frix-x Dec 20, 2023

Choose a reason for hiding this comment

Frix-x left a comment

Choose a reason for hiding this comment

Frix-x Dec 20, 2023

Choose a reason for hiding this comment

Surion79 commented Dec 20, 2023

claudioguareschi commented Dec 20, 2023

Surion79 commented Dec 20, 2023

Frix-x commented Dec 20, 2023

Surion79 commented Dec 20, 2023

Benoitone commented Dec 20, 2023

Benoitone commented Dec 20, 2023

Surion79 commented Dec 20, 2023 • edited Loading

Surion79 commented Dec 20, 2023

Frix-x commented Dec 21, 2023

Frix-x commented Dec 21, 2023

Surion79 commented Dec 20, 2023 •

edited

Loading