Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable.cfg setting to control cale leds at startup #419

Closed
wants to merge 156 commits into from

Conversation

claudioguareschi
Copy link
Contributor

As above

Surion79 and others added 30 commits December 2, 2023 23:43
Co-authored-by: Félix Boisselier <felix@fboisselier.fr>
Add comment about required current. At the default of 0.45 on the Orbiter 2 motor, very poor performance will occur including significant underextrusion on infill, etc.
@Benoitone
Copy link
Collaborator

Can you make this PR only based on the new branch leds-rework?

@claudioguareschi
Copy link
Contributor Author

Can you make this PR only based on the new branch leds-rework?

Be glad to do that but I need some guidance on how to do it. I am not good with github stuff. If you can give me a little help will be glad to streamline this as much as possible

@Benoitone
Copy link
Collaborator

Can you make this PR only based on the new branch leds-rework?

Be glad to do that but I need some guidance on how to do it. I am not good with github stuff. If you can give me a little help will be glad to streamline this as much as possible

for exemple in your own klippain fork repo create a new branch name for exemple leds_rework like that:
fork repo
and then you can modify this branch to create your PR in Klippain.

@claudioguareschi
Copy link
Contributor Author

Thanks, done

@Frix-x
Copy link
Owner

Frix-x commented Feb 1, 2024

I'm closing this since there was a big merge done in the develop with all the work you've done already and some minor modifications :)
Thank you very much for the work!

If you think it's not perfect, I'll let you open a new PR against the latest version in develop to start from a clean repo, it will be easier :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants