Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(QuoteBlock): prevent text from overflowing outside container #996

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix(QuoteBlock): prevent text from overflowing outside container #996

merged 2 commits into from
Jan 24, 2025

Conversation

peter-tudosa
Copy link
Contributor

Ticket: CU-8697g24cc

Before:
image
image

After:
image
image

@peter-tudosa peter-tudosa requested a review from a team as a code owner January 20, 2025 13:55
@fulopdaniel
Copy link
Collaborator

Awesome fix. Two issue I found is the author is sometimes broken into two lines, and sometimes it is cut off.

image
image

@ragi96 ragi96 removed their request for review January 20, 2025 17:07
@peter-tudosa
fix(QuoteBlock): prevent text from overflowing outside container
3ca7875 
Signed-off-by: Peter Tudosa <razvan-petru.tudosa@frontify.com>
@peter-tudosa peter-tudosa force-pushed the fix-quote-block-text-overflow branch from b02e15a to 3ca7875 Compare January 24, 2025 08:42
@peter-tudosa
fix(QuoteBlock): prevent author text cutout
79252ec 
Signed-off-by: Peter Tudosa <razvan-petru.tudosa@frontify.com>
@peter-tudosa
Copy link
Contributor Author

Awesome fix. Two issue I found is the author is sometimes broken into two lines, and sometimes it is cut off.

image image

@fulopdaniel I added a break-all on the author text to prevent that weird cutout of text.

fulopdaniel
fulopdaniel approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@fulopdaniel fulopdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@peter-tudosa peter-tudosa merged commit c5c7b02 into main Jan 24, 2025
10 checks passed
@peter-tudosa peter-tudosa deleted the fix-quote-block-text-overflow branch January 24, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulopdaniel fulopdaniel fulopdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter-tudosa @fulopdaniel