Reintroduce inputBools with tighter definition #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frouk3
reviewed
Apr 30, 2024
| int field_E60; | ||
| int field_E64; | ||
| int field_E68; | ||
| int inputBools[25]; |
There was a problem hiding this comment.
we do member prefix like m_variablename
Frouk3
reviewed
Apr 30, 2024
| int field_E6C; | ||
| int field_E70; | ||
| int field_E74; | ||
| int field_E78; | ||
| int field_E7C; | ||
| float field_E80; | ||
| float field_E84; | ||
| float heavy_attack_count_up; |
There was a problem hiding this comment.
same as comment in inputBools but should be like m_fVariableName and probably without _
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like that's a much tighter bound on the array being compared here. Also, add a few floats I stumbled on (and name field_E80 and field_E84, we don't need to be cryptic with addresses on purpose).