Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate closing brace after \t #669

Closed
unhammer opened this issue Nov 3, 2016 · 1 comment
Closed

duplicate closing brace after \t #669

unhammer opened this issue Nov 3, 2016 · 1 comment
Labels
bug scope:quotes
Milestone
1.10

Comments

@unhammer
Copy link

unhammer commented Nov 3, 2016 •
edited
Loading

After writing \t and then [, the closing ] is inserted. Then, when typing the ] to skip over the closing brace, a second ] is inserted. This doesn't happen if there's no \t before. Newlines after the \t don't help, and it goes for other parens types too. Extra \t's do not cancel the effect.

See https://asciinema.org/a/1uzd1icbenzjtrif1d55w0lty for demonstration running under emacs -Q.

asciicast
@Fuco1
Copy link
Owner

Fuco1 commented Nov 3, 2016

Thanks, this looks annoying, I'll look into it.

@Fuco1 Fuco1 modified the milestones: 1.9, 1.10 Nov 3, 2016
@Fuco1 Fuco1 closed this as completed in ce2f46b Nov 13, 2016
@Fuco1 Fuco1 mentioned this issue Nov 13, 2016
Closed
Fuco1 added a commit that referenced this issue Nov 13, 2016
@Fuco1
[#668] Add tests for this issue.
05959f6 
This was fixed in #669.
jojojames pushed a commit to jojojames/smartparens that referenced this issue Mar 31, 2017
@Fuco1 @jojojames
[Fix Fuco1#669] Use sp-char-is-escaped-p to detect escaped characters.
72f157c 
The issue was that by using sp--search-backward-regexp we allowed checks
which did not end on point and so could pick up any escaped character
previously inserted in the buffer.
jojojames pushed a commit to jojojames/smartparens that referenced this issue Mar 31, 2017
@Fuco1 @jojojames
[Fuco1#668] Add tests for this issue.
07d15f1 
This was fixed in Fuco1#669.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug scope:quotes
Projects
None yet
Milestone
1.10
Development

No branches or pull requests
2 participants
@unhammer @Fuco1