Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't autocomplete the lua blocks when inside comments #648

Merged
merged 4 commits into from
Sep 26, 2016

Conversation

bunelr
Copy link
Contributor

@bunelr bunelr commented Sep 12, 2016

Hello,

First of all, thanks for smartparens, I use it all the time :)

I have some small gripes with smartparens-lua:

At the moment, if you're in a Lua buffer and you are writing comments,

-- Do this for|

and you press SPC, you'll get autocompleted

-- Do this for | do
    end

which is problematic because you have to watch out for the words you use in the comments to avoid getting spurious completion.

I don't see a case where you would want to have this auto-completed when you're writing comments but I might be wrong.

What do you think?

@Fuco1
Copy link
Owner

Fuco1 commented Sep 12, 2016

I think this is reasonable :)

Do you know how to write tests? You can look into tests/...python-test, but don't forget to add (require 'smartparens-lua) on top :) If not that's fine too.

@bunelr
Copy link
Contributor Author

bunelr commented Sep 12, 2016

Sure, sorry I didn't include any.
I'll add some tests later tonight when I come home.

(I don't think the current failing test is related though)

Cheers

@Fuco1
Copy link
Owner

Fuco1 commented Sep 12, 2016

The current test fail is some magical incompatibility with emacs 24.3. I'll need to figure out how to label it "allowed to fail" :o Thanks.

@bunelr
Copy link
Contributor Author

bunelr commented Sep 13, 2016

Tests added :)

@Fuco1
Copy link
Owner

Fuco1 commented Sep 13, 2016

Great! Thank you very much.

@bunelr
Copy link
Contributor Author

bunelr commented Sep 26, 2016

Resolved the merge conflict by merging Master back into this branch.
The problem was in the Cask file, addition of required elements were added in 9eed758 at the same time.

@Fuco1 Fuco1 merged commit 0e47f4a into Fuco1:master Sep 26, 2016
@Fuco1
Copy link
Owner

Fuco1 commented Sep 26, 2016

Great, thanks for the contribution!

@bunelr bunelr deleted the lua-no-comment branch September 26, 2016 16:25
jojojames pushed a commit to jojojames/smartparens that referenced this pull request Mar 31, 2017
Don't autocomplete the lua blocks when inside comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants