Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript-mode to smartparens-javascript.el #748

Merged
merged 1 commit into from
May 24, 2017

Conversation

arichiardi
Copy link
Contributor

The fix you suggested worked so I am PR-ing it 😄

Thanks a lot!

I will probably do the same for reason-mode, which I am maintaining, at some point.

@Fuco1
Copy link
Owner

Fuco1 commented May 24, 2017

Great, thanks for confirming and adding this!

If you maintain a mode and would like to support further smartparens configuration I'm pretty open with granting collaborator membership so people can manage "their own stuff" here (I usually prefer it to providing config in the modes themselves but it's up to the maintainers). If you will be interested just ping me and we'll make it happen.

@Fuco1 Fuco1 merged commit a758dd1 into Fuco1:master May 24, 2017
@arichiardi arichiardi deleted the support-typescript branch May 24, 2017 23:05
@arichiardi
Copy link
Contributor Author

@Fuco1 yeah I haven't decided about embedding or not yet. It is a good option for me to hijack either smartparens-ml.el or smartparens-javascript.el for now. I don't see the configuration too far from Javascript/Rust for instance, even if Reason is a dialect of OCaml. In any case, thanks for solving the problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants