Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the chain config's name #1

Closed
xgreenx opened this issue May 30, 2024 · 1 comment
Closed

Updated the chain config's name #1

xgreenx opened this issue May 30, 2024 · 1 comment
Assignees

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented May 30, 2024

When FuelLabs/fuel-core#1919 is ready and released. We need to update the name to be "Fuel Sepolia Testnet".

@xgreenx xgreenx self-assigned this Jun 10, 2024
@MitchTurner
Copy link
Member

This is probably too complex for the testnet users, and probably not worth doing now. We should support changing of the chain config for future networks however.

@xgreenx xgreenx closed this as completed Jun 20, 2024
xgreenx added a commit to FuelLabs/fuel-core that referenced this issue Aug 15, 2024
Closes #1901
Closes #1919

The `ConsensusConfig` now contains one more variant, `PoAV2`, that also
overrides the PoA at specific block heights. It means that starting this
block the node expects blocks signed by another PoA key.

Along with that, I've added additional features to automate the
migration of the state so it is compatible with the new chain
configuration:
- During start-up, the `fuel-core` binary checks if there are any
changes in the chain config. If they are, the binary re-inserts the new
`Conesnsus::Genesis` type in the `SealedBlockConsensus` table. Now we
can do FuelLabs/chain-configuration#1.
- The `fuel-core` to react to `signing_key_overrides`. If the blocks at
the corresponding overwritten block height have different signers, the
`fuel-core` rollbacks to the height before overriding occurs.

Side changes:
- Renamed the methods of the `FuelService` to be more explicit on the
logic.
- Moved business logic from `FuelService::Task` to `FuelService`.

## Checklist
- [x] New behavior is reflected in tests

### Before requesting review
- [x] I have reviewed the code myself
GoldenPath1109 added a commit to GoldenPath1109/fuel-core that referenced this issue Sep 7, 2024
Closes FuelLabs/fuel-core#1901
Closes FuelLabs/fuel-core#1919

The `ConsensusConfig` now contains one more variant, `PoAV2`, that also
overrides the PoA at specific block heights. It means that starting this
block the node expects blocks signed by another PoA key.

Along with that, I've added additional features to automate the
migration of the state so it is compatible with the new chain
configuration:
- During start-up, the `fuel-core` binary checks if there are any
changes in the chain config. If they are, the binary re-inserts the new
`Conesnsus::Genesis` type in the `SealedBlockConsensus` table. Now we
can do FuelLabs/chain-configuration#1.
- The `fuel-core` to react to `signing_key_overrides`. If the blocks at
the corresponding overwritten block height have different signers, the
`fuel-core` rollbacks to the height before overriding occurs.

Side changes:
- Renamed the methods of the `FuelService` to be more explicit on the
logic.
- Moved business logic from `FuelService::Task` to `FuelService`.

## Checklist
- [x] New behavior is reflected in tests

### Before requesting review
- [x] I have reviewed the code myself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants