New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(publisher): Publish receipts #208

Merged

pedronauck merged 7 commits into main from aj/DS-14/receipts-implement-logic-on-publisher

Sep 13, 2024

Member

Jurshsmith commented Sep 9, 2024 •

edited

Loading

References:

Jurshsmith requested review from luizstacio, pedronauck, lostman and 0xterminator as code owners

September 9, 2024 11:48

Jurshsmith force-pushed the aj/DS-14/receipts-implement-logic-on-publisher branch from 5e9d158 to a005c1b Compare

September 9, 2024 11:50

Jurshsmith commented

View reviewed changes

crates/fuel-streams-core/src/receipts/subjects.rs Show resolved Hide resolved

Jurshsmith commented

View reviewed changes

crates/fuel-streams-core/src/receipts/subjects.rs Show resolved Hide resolved

Jurshsmith commented

View reviewed changes

crates/fuel-streams-macros/src/lib.rs Show resolved Hide resolved

Jurshsmith commented

View reviewed changes

crates/fuel-streams-publisher/src/fuel_core.rs Show resolved Hide resolved

Jurshsmith force-pushed the aj/DS-14/receipts-implement-logic-on-publisher branch 2 times, most recently from e11747c to 065a457 Compare

September 9, 2024 12:16

Jurshsmith self-assigned this

Jurshsmith commented

View reviewed changes

tests/tests/publisher.rs Show resolved Hide resolved

Jurshsmith force-pushed the aj/DS-14/receipts-implement-logic-on-publisher branch from 065a457 to 1e41e0d Compare

September 9, 2024 12:40

pedronauck requested changes

View reviewed changes

crates/fuel-streams-core/src/stream/stream_impl.rs Show resolved Hide resolved

crates/fuel-streams-macros/src/lib.rs Show resolved Hide resolved

crates/fuel-streams-publisher/src/main.rs Outdated Show resolved Hide resolved

crates/fuel-streams-publisher/src/publisher.rs Show resolved Hide resolved

lostman previously approved these changes

View reviewed changes

Contributor

lostman left a comment

Looking good 👍

crates/fuel-streams-macros/src/lib.rs Show resolved Hide resolved

0xterminator reviewed

View reviewed changes

crates/fuel-streams-core/src/types.rs Show resolved Hide resolved

crates/fuel-streams-macros/src/lib.rs Show resolved Hide resolved

Contributor

0xterminator commented Sep 11, 2024

Great stuff! Once you resolve the few tiny comments, I believe its good to go!

Jurshsmith dismissed lostman’s stale review via

b42b96a

September 11, 2024 07:16

Jurshsmith requested review from 0xterminator, lostman and pedronauck

September 11, 2024 07:20

0xterminator previously approved these changes

View reviewed changes

Jurshsmith added 6 commits

September 12, 2024 20:47


          refactor(fuel-streams-macros): make IntoSubject object safe

26d4c79

This commit introduces `SubjectBuildable` to house `new()` building fn
to ensure `IntoSubject` is object safe with the sole purpose of allowing
list composable Subjects


          refactor(publisher): introduce trait to simplify mocking in integrati…

4eabaea

…on tests


          feat(publisher): allow publishing receipts


          fix(ci): add back NATS env variables

63fb0fb


          fix(ci): remove unused env creation step

b93fea0


          refactor(core): allow publishing many boxed subjects dynamically

5a17c4b

Jurshsmith dismissed 0xterminator’s stale review via

0a6f591

September 12, 2024 20:07

Jurshsmith force-pushed the aj/DS-14/receipts-implement-logic-on-publisher branch from b42b96a to 0a6f591 Compare

September 12, 2024 20:07


          refactor(core): publish many concurrently

63c508a

Jurshsmith force-pushed the aj/DS-14/receipts-implement-logic-on-publisher branch from 0a6f591 to 63c508a Compare

September 12, 2024 20:29

Jurshsmith requested a review from 0xterminator

September 12, 2024 20:36

0xterminator approved these changes

View reviewed changes

pedronauck approved these changes

View reviewed changes

pedronauck merged commit 103625b into main

15 checks passed

pedronauck deleted the aj/DS-14/receipts-implement-logic-on-publisher branch

September 13, 2024 16:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

0xterminator 0xterminator approved these changes

pedronauck pedronauck approved these changes

luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

lostman Awaiting requested review from lostman

Labels

None yet