Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publisher): Publish outputs #211

Merged
merged 10 commits into from
Sep 20, 2024
Merged

feat(publisher): Publish outputs #211

merged 10 commits into from
Sep 20, 2024

Conversation

lostman
Copy link
Contributor

@lostman lostman commented Sep 11, 2024

@lostman lostman changed the title feat(outputs): publish outputs feat(publisher): publish outputs Sep 11, 2024
@lostman lostman changed the title feat(publisher): publish outputs feat(publisher): ublish outputs Sep 11, 2024
@lostman lostman changed the title feat(publisher): ublish outputs feat(publisher): Publish outputs Sep 11, 2024
crates/fuel-streams-core/src/outputs/subjects.rs Outdated Show resolved Hide resolved
crates/fuel-streams-core/src/outputs/subjects.rs Outdated Show resolved Hide resolved
crates/fuel-streams-core/src/outputs/subjects.rs Outdated Show resolved Hide resolved
@0xterminator
Copy link
Contributor

@lostman Please fix the little suggestions by rust here: https://github.com/FuelLabs/data-systems/actions/runs/10889181254/job/30215368841?pr=211 to make the pipeline flash all green

@0xterminator
Copy link
Contributor

@lostman I think you need to rebase and add the metrics analogically to the other subjects - txs, receipts etc. Rest looks good on my end!

0xterminator
0xterminator previously approved these changes Sep 18, 2024
@lostman
Copy link
Contributor Author

lostman commented Sep 18, 2024

@lostman, I think you need to rebase and add the metrics analogically to the other subjects - txs, receipts, etc. Rest looks good on my end!

Yeah, I see the merge conflicts. I'm on it.

@lostman lostman marked this pull request as ready for review September 18, 2024 18:18
@lostman lostman requested a review from pedronauck September 18, 2024 18:18
@pedronauck pedronauck merged commit 8548f06 into main Sep 20, 2024
15 checks passed
@pedronauck pedronauck deleted the mw/ds-22/outputs branch September 20, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants