feat(publisher): Introduce Telemetry #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the `FuelCoreLike` trait definition allowing us to wrap implementors in a `Arc` reference
Jurshsmith
requested review from
luizstacio,
pedronauck and
0xterminator
as code owners
Jurshsmith
force-pushed
the
aj/DS-109/introduce-telemetry
branch
2 times, most recently
from
6bf7099 to
06e8bd3
Compare
Jurshsmith
commented
Nov 2, 2024
| @@ -11,6 +11,7 @@ SURREALDB_URL=127.0.0.1:8000 | |||
| SURREALDB_USER=root | |||
| SURREALDB_PASS=root | |||
| CONCURRENCY_LIMIT=16 | |||
| USE_ELASTIC_LOGGING=false | |||
There was a problem hiding this comment.
We'll need to include this environment variable before deploying
Comment on lines
-34
to
-41
| #[arg( | ||
| long, | ||
| value_name = "ELOG", | ||
| env = "USE_ELASTIC_LOGGING", | ||
| default_value = "false", | ||
| help = "Use elasticsearch logging." | ||
| )] | ||
| pub use_elastic_logging: bool, |
There was a problem hiding this comment.
Removed this in a bid to reduce the CLI args.
Comment on lines
-193
to
-212
| // fn set_panic_hook(&mut self) { | ||
| // let nats_client = self.nats_client.clone(); | ||
| // let fuel_service = Arc::clone(&self.fuel_service); | ||
| // std::panic::set_hook(Box::new(move |panic_info| { | ||
| // let payload = panic_info | ||
| // .payload() | ||
| // .downcast_ref::<&str>() | ||
| // .unwrap_or(&"Unknown panic"); | ||
| // tracing::error!("Publisher panicked with a message: {:?}", payload); | ||
| // let handle = tokio::runtime::Handle::current(); | ||
| // let nats_client = nats_client.clone(); | ||
| // let fuel_service = Arc::clone(&fuel_service); | ||
| // handle.spawn(async move { | ||
| // Publisher::flush_await_all_streams(&nats_client).await; | ||
| // Publisher::stop_fuel_service(&fuel_service).await; | ||
| // std::process::exit(1); | ||
| // }); | ||
| // })); | ||
| // } | ||
|
|
There was a problem hiding this comment.
We will need a new small task for graceful shutdown when Publisher panics
Comment on lines
+93
to
+96
| fn maybe_elog(&self, entry: LogEntry) { | ||
| if let Some(elastic_search) = &self.elastic_search { | ||
| self.runtime | ||
| .spawn(elastic_search::log(elastic_search.clone(), entry)); | ||
| } | ||
| } |
There was a problem hiding this comment.
This happens within the Telemetry's dedicated ThreadPool, so, we no longer have to delay processing the next block because of ElasticSearch
This change consolidates all things related to metrics and logging in a dedicated Telemetry process to give room for processing performance when publishing.
Jurshsmith
force-pushed
the
aj/DS-109/introduce-telemetry
branch
from
87704db to
49f4e0c
Compare
Jurshsmith
force-pushed
the
aj/DS-109/introduce-telemetry
branch
from
c66d993 to
621507c
Compare
Jurshsmith
commented
Nov 11, 2024
| .enable_all() | ||
| .build()?; | ||
|
|
||
| runtime.block_on(async { |
There was a problem hiding this comment.
We don't need these block_ons
| let server_handle = server.handle(); | ||
| // spawn the server in the background | ||
| tokio::spawn(async move { |
There was a problem hiding this comment.
This should have been server_runtime.spawn
| let (tx, rx) = mpsc::channel::<RuntimeMessage>(100); | ||
| let cli = cli.clone(); | ||
|
|
||
| tokio::spawn({ |
There was a problem hiding this comment.
this shoould have been publisher_runtime.spawn
|
|
||
| tokio::spawn(async move { |
There was a problem hiding this comment.
This should have been fuel_core_runtime.spawn
| @@ -1,188 +1,64 @@ | |||
| //! This binary subscribes to events emitted from a Fuel client or node | |||
There was a problem hiding this comment.
Let's keep the main binary in its former shape for now, and then plan around the runtime architecture for each of its processes.
Jurshsmith
force-pushed
the
aj/DS-109/introduce-telemetry
branch
from
54f7844 to
d943cde
Compare
pedronauck
reviewed
Nov 12, 2024
0xterminator
approved these changes
Nov 12, 2024
pedronauck
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change consolidates all things related to metrics and logging in a dedicated
Telemetry process to give room for processing performance when publishing.
Closes DS-109