Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(publisher): Added entries max retention time #309

Merged
merged 6 commits into from
Nov 12, 2024
Merged

feat(publisher): Added entries max retention time #309

merged 6 commits into from
Nov 12, 2024

Conversation

0xterminator
Copy link
Contributor

@0xterminator 0xterminator commented Nov 12, 2024 •
edited
Loading

This PR adds:

  • max retention time for all entries in nats = 100 blocks (100 * 1 sec)
  • skips syncing with blocks whose times are before the last 100.

@0xterminator 0xterminator self-assigned this Nov 12, 2024
@0xterminator 0xterminator force-pushed the fix/eugene/retention-time branch from 5879bea to e253e34 Compare November 12, 2024 10:08
pedronauck
pedronauck previously approved these changes Nov 12, 2024
View reviewed changes
Jurshsmith
Jurshsmith previously approved these changes Nov 12, 2024
View reviewed changes
@0xterminator 0xterminator dismissed stale reviews from Jurshsmith and pedronauck via ba16de9 November 12, 2024 10:37
@0xterminator 0xterminator force-pushed the fix/eugene/retention-time branch from e253e34 to ba16de9 Compare November 12, 2024 10:37
@0xterminator 0xterminator merged commit 44ea206 into main Nov 12, 2024
15 checks passed
@0xterminator 0xterminator deleted the fix/eugene/retention-time branch November 12, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedronauck pedronauck pedronauck approved these changes

@Jurshsmith Jurshsmith Jurshsmith approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

Assignees

@0xterminator 0xterminator

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xterminator @pedronauck @Jurshsmith