fix(publisher): Resolve block publication race conditions and synchronization issues #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jurshsmith
requested review from
luizstacio,
pedronauck and
0xterminator
as code owners
Jurshsmith
force-pushed
the
fix/DS-124/fix-transactions-not-being-streamed-with-receipts
branch
from
4dcb1b7 to
452a400
Compare
Jurshsmith
changed the title
Jurshsmith
force-pushed
the
fix/DS-124/fix-transactions-not-being-streamed-with-receipts
branch
from
452a400 to
63617d7
Compare
… order This commit addresses two key issues in the publisher module: OffchainDB synchronization: Previously, receipts were not being populated because the OffchainDB lagged behind the OnChainDB. This has been resolved by ensuring the OffchainDB is fully synchronized to the current height before publishing any streams. In the future, separating streams into distinct processes could avoid delays for streams that do not depend on OffchainDB synchronization. Old and new blocks synchronization: The previous implementation used a blocking while loop to process old blocks until the latest block. This approach delayed the subscription to new blocks, causing significant block misses in the subscription stream. To resolve this, an UnpublishedBlocks abstraction has been introduced. It allows the system to subscribe to new blocks immediately, even while syncing old blocks. Blocks are now published in the correct order based on their heights, ensuring no data is missed or processed out of sequence. References: DS-124
Jurshsmith
force-pushed
the
fix/DS-124/fix-transactions-not-being-streamed-with-receipts
branch
from
63617d7 to
aa7b930
Compare
0xterminator
approved these changes
Dec 2, 2024
pedronauck
approved these changes
Dec 2, 2024
pedronauck
deleted the
fix/DS-124/fix-transactions-not-being-streamed-with-receipts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current blocks stream publishing mechanism suffers from two critical synchronization challenges:
Receipt Population Failure: Blocks were not being populated with receipts due to the OffchainDB being out of sync with the OnChainDB.
Block Synchronization Bottleneck: The existing block import mechanism used a blocking synchronization approach that:
Solution
This commit introduces the
UnpublishedBlocksabstraction to resolve these issues:Future Improvements
As a potential optimization, when streams are separated into different processes, we can further refine the synchronization strategy to avoid waiting for OffchainDB sync for certain stream types.
References: DS-124