fix(publisher): Simplify and test BlocksStream for old and new blocks #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jurshsmith
requested review from
luizstacio,
pedronauck and
0xterminator
as code owners
pedronauck
previously approved these changes
Dec 5, 2024
Jurshsmith
force-pushed
the
aj/fix-publisher-performance
branch
from
0d69eb4 to
5c9463c
Compare
Jurshsmith
changed the title
fuel-core service
Jurshsmith
changed the title
fuel-core service
Jurshsmith
force-pushed
the
aj/fix-publisher-performance
branch
from
97f7857 to
9629434
Compare
…re` service This fix gets rid of `UnpublishedBlocks` abstraction in favor of dynamically computing the stream until it has published the latest height -- at this point, it subscribes to the block importer for new blocks
BlocksStream now streams old blocks until reaching the latest chain height, after which it subscribes to new blocks from the fuel-core importer. This refactor removes the need for the UnpublishedBlocks abstraction, which previously managed batches of blocks but caused contention issues, starving fuel-core of its synchronization capacity. By simplifying the block-handling logic, this fix improves performance, reduces complexity, and ensures fuel-core can sync effectively.
This will allow the local OnChainDB to stay ahead of our blocks streaming subscription to avoid subscribing to the new blocks stream prematurely
Jurshsmith
force-pushed
the
aj/fix-publisher-performance
branch
from
892a04b to
7029d1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlocksStream now streams old blocks until reaching the latest chain height,
after which it subscribes to new blocks from the fuel-core importer.
This refactor removes the need for the UnpublishedBlocks abstraction, which
previously managed batches of blocks but caused contention issues, starving
fuel-core of its synchronization capacity.
By simplifying the block-handling logic, this fix improves performance, reduces
complexity, and ensures fuel-core can sync effectively.