Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add redirect and autoClose features #73

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

luizstacio
Copy link
Member

@luizstacio luizstacio commented Jul 15, 2024

This PR adds;

  • A new query param to receive a redirectUrl to redirect the user after receiving a faucet.
  • Adds a UI the indicates that the user will be redirected back to the previous host.
  • Adds a query param to the redirected application URL with the tx_id
  • Adds a autoClose params also that can be use to close the tab once fauce is complete
Screen.Recording.2024-07-15.at.5.33.31.PM.mp4

@luizstacio luizstacio marked this pull request as draft July 15, 2024 20:30
@luizstacio luizstacio marked this pull request as ready for review July 31, 2024 02:45
@luizstacio luizstacio changed the title feat: add redirect param to improve UX feat: add redirect and autoClose features Jul 31, 2024
@matt-user matt-user requested review from Voxelot, xgreenx and MujkicA July 31, 2024 12:28
Copy link
Member

@MitchTurner MitchTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I'm hardly a knowledgeable JS person, so I'm not sure how good my eye is for this :)

@luizstacio luizstacio requested a review from LuizAsFight August 5, 2024 19:54
@luizstacio luizstacio merged commit 03ec0dd into master Aug 7, 2024
8 checks passed
@luizstacio luizstacio deleted the ls/chore/add-redirect branch August 7, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants