-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use new core and sdk, fix broken code #77
Conversation
@@ -150,7 +150,7 @@ async fn get_coins( | |||
amount: u64, | |||
) -> Result<Vec<Input>, DispenseError> { | |||
wallet | |||
.get_spendable_resources(*base_asset_id, amount) | |||
.get_spendable_resources(*base_asset_id, amount, None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the last value here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's "excluded" coins:
/// Get some spendable resources (coins and messages) of asset `asset_id` owned by the account
/// that add up at least to amount `amount`. The returned coins (UTXOs) are actual coins that
/// can be spent. The number of UXTOs is optimized to prevent dust accumulation.
async fn get_spendable_resources(
&self,
asset_id: AssetId,
amount: u64,
excluded_coins: Option<Vec<CoinTypeId>>,
) -> Result<Vec<CoinType>> {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, not great docs on it, but if it passes the tests...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, i would suggest to fmt the code, and inspect why strum_macros
has multiple versions in the Cargo.lock
It looks like we just depend on multiple versions. |
Context:
Bumped versions and fixed all the broken pieces.