Bump forc to 0.56, rust sdk to 0.60, adapt predicate to new encoding #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is published in NPM with version **** |
Voxelot
reviewed
May 14, 2024
K1-R1
reviewed
May 16, 2024
packages/message-predicates/contract-message-predicate/script_asm.rs
Outdated
Show resolved
Hide resolved
packages/message-predicates/contract-message-predicate/script_asm.rs
Outdated
Show resolved
Hide resolved
packages/message-predicates/contract-message-predicate/script_asm.rs
Outdated
Show resolved
Hide resolved
…asm.rs Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
K1-R1
approved these changes
May 17, 2024
DefiCake
pushed a commit
that referenced
this pull request
Sep 6, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @fuel-bridge/fungible-token@0.6.0 ### Minor Changes - Upgrade all dependencies to fuel-core 0.27, by [@SwayStar123](https://github.com/SwayStar123) (See [#201](#201)) - Bump ts-sdk to 0.94.4, by [@DefiCake](https://github.com/DefiCake) (See [#277](#277)) - remove unused mapping, by [@viraj124](https://github.com/viraj124) (See [#258](#258)) - Architecture revamp featuring single asset issuer on L2, by [@DefiCake](https://github.com/DefiCake) (See [#150](#150)) - Bump all packages to adhere to fuel-core 0.26, forc 0.56, fuel-rs 0.60, fuel-ts 0.85, by [@DefiCake](https://github.com/DefiCake) (See [#180](#180)) - Update forc to 0.63.3, by [@DefiCake](https://github.com/DefiCake) (See [#265](#265)) - Upgraded fuel dependencies to fuel-core 0.33, by [@DefiCake](https://github.com/DefiCake) (See [#237](#237)) - Implement SRC-7 and SRC-20, by [@DefiCake](https://github.com/DefiCake) (See [#240](#240)) - Added upgradability to bridge contracts, by [@DefiCake](https://github.com/DefiCake) (See [#164](#164)) - Add typegen for fuel ts sdk and a deploy script for the bridge. Bump fuel-core to v0.31.0, by [@DefiCake](https://github.com/DefiCake) (See [#222](#222)) - Upgraded ts-sdk to 0.94.3, by [@DefiCake](https://github.com/DefiCake) (See [#271](#271)) - Use custom error for relay unknown error reverts, by [@DefiCake](https://github.com/DefiCake) (See [#178](#178)) - Update fuel-core to v0.26.0 and all sdk dependencies needed to track it, by [@DefiCake](https://github.com/DefiCake) (See [#161](#161)) ### Patch Changes - Update documentation, by [@DefiCake](https://github.com/DefiCake) (See [#197](#197)) - Use L1 token decimals to determine L2 token decimals, by [@DefiCake](https://github.com/DefiCake) (See [#166](#166)) - Add reentrancy unit test for l2 proxy-bridge, by [@DefiCake](https://github.com/DefiCake) (See [#221](#221)) - Add comments to Hexens audit. Fix some other in-code commentary, by [@DefiCake](https://github.com/DefiCake) (See [#177](#177)) - Remove unused code in L2 bridge, by [@DefiCake](https://github.com/DefiCake) (See [#259](#259)) - Removed unused and vulnerable npm dependencies, by [@DefiCake](https://github.com/DefiCake) (See [#212](#212)) - Bump forc and ts version, by [@DefiCake](https://github.com/DefiCake) (See [#162](#162)) ## @fuel-bridge/message-predicates@0.6.0 ### Minor Changes - Upgrade all dependencies to fuel-core 0.27, by [@SwayStar123](https://github.com/SwayStar123) (See [#201](#201)) - Bump all packages to adhere to fuel-core 0.26, forc 0.56, fuel-rs 0.60, fuel-ts 0.85, by [@DefiCake](https://github.com/DefiCake) (See [#180](#180)) - Upgraded fuel dependencies to fuel-core 0.33, by [@DefiCake](https://github.com/DefiCake) (See [#237](#237)) - Implement SRC-7 and SRC-20, by [@DefiCake](https://github.com/DefiCake) (See [#240](#240)) - Added upgradability to bridge contracts, by [@DefiCake](https://github.com/DefiCake) (See [#164](#164)) - Update fuel-core to v0.26.0 and all sdk dependencies needed to track it, by [@DefiCake](https://github.com/DefiCake) (See [#161](#161)) ### Patch Changes - Update documentation, by [@DefiCake](https://github.com/DefiCake) (See [#197](#197)) - Removed unused and vulnerable npm dependencies, by [@DefiCake](https://github.com/DefiCake) (See [#212](#212)) - Bump forc and ts version, by [@DefiCake](https://github.com/DefiCake) (See [#162](#162)) ## @fuel-bridge/solidity-contracts@0.6.0 ### Minor Changes - add eth rate limiter, by [@viraj124](https://github.com/viraj124) (See [#228](#228)) - Adds FuelMessagePortalV3 with increased granularity on withdrawals control, by [@DefiCake](https://github.com/DefiCake) (See [#148](#148)) - Adapted deployments for a full e2e environment, and minor util adaptions to anvil quirks, by [@DefiCake](https://github.com/DefiCake) (See [#229](#229)) - 🐞 fix pnpm audit findings, by [@PraneshASP](https://github.com/PraneshASP) (See [#247](#247)) - reset rate limit script, by [@viraj124](https://github.com/viraj124) (See [#254](#254)) - Added FuelChainState setter to FuelMessagePortalV3, by [@DefiCake](https://github.com/DefiCake) (See [#234](#234)) - Deploy devnet and testnet contracts, by [@DefiCake](https://github.com/DefiCake) (See [#175](#175)) - 🐞 Fix depositToken naming, by [@DefiCake](https://github.com/DefiCake) (See [#273](#273)) - 🐞 Fix ECDSA test flakiness, by [@DefiCake](https://github.com/DefiCake) (See [#144](#144)) - Add recommit protection in FuelChainState, by [@DefiCake](https://github.com/DefiCake) (See [#174](#174)) - remove unused mapping, by [@viraj124](https://github.com/viraj124) (See [#258](#258)) - Architecture revamp featuring single asset issuer on L2, by [@DefiCake](https://github.com/DefiCake) (See [#150](#150)) - Ported @fuel-contracts/merkle-sol utils, by [@DefiCake](https://github.com/DefiCake) (See [#196](#196)) - FuelChainState is now configurable in deployment scripts, by [@DefiCake](https://github.com/DefiCake) (See [#204](#204)) - erc20 rate limit, by [@viraj124](https://github.com/viraj124) (See [#239](#239)) - Bump all packages to adhere to fuel-core 0.26, forc 0.56, fuel-rs 0.60, fuel-ts 0.85, by [@DefiCake](https://github.com/DefiCake) (See [#180](#180)) - add `_disableInitializers()` to FuelMessagePortal V2 and V3, by [@PraneshASP](https://github.com/PraneshASP) (See [#248](#248)) - Add relay deposit script, by [@DefiCake](https://github.com/DefiCake) (See [#266](#266)) - add disable initializer in erc20 v4 gateway, by [@viraj124](https://github.com/viraj124) (See [#261](#261)) - Added upgradability to bridge contracts, by [@DefiCake](https://github.com/DefiCake) (See [#164](#164)) - Extract CommonPredicates lib into its own file, by [@DefiCake](https://github.com/DefiCake) (See [#142](#142)) - Use custom error for relay unknown error reverts, by [@DefiCake](https://github.com/DefiCake) (See [#178](#178)) - Update fuel-core to v0.26.0 and all sdk dependencies needed to track it, by [@DefiCake](https://github.com/DefiCake) (See [#161](#161)) - Added hardhat scripts, by [@DefiCake](https://github.com/DefiCake) (See [#190](#190)) - add zero address check for asset issuer id, by [@viraj124](https://github.com/viraj124) (See [#250](#250)) ### Patch Changes - Deployment of new devnet, by [@DefiCake](https://github.com/DefiCake) (See [#157](#157)) - Add deprecation notices and use better folder grouping, by [@DefiCake](https://github.com/DefiCake) (See [#171](#171)) - Update documentation, by [@DefiCake](https://github.com/DefiCake) (See [#197](#197)) - Add nonce to FTI interface, by [@DefiCake](https://github.com/DefiCake) (See [#155](#155)) - Deploy new token bridge to devnet, by [@DefiCake](https://github.com/DefiCake) (See [#233](#233)) - 🐞 Fix encoding issue on FuelERC20GatewayV4.sendMetadata(), by [@DefiCake](https://github.com/DefiCake) (See [#169](#169)) - Add migration files of FuelChainState testnet upgrade - withdrawal period extension, by [@DefiCake](https://github.com/DefiCake) (See [#207](#207)) - Use L1 token decimals to determine L2 token decimals, by [@DefiCake](https://github.com/DefiCake) (See [#166](#166)) - 🐞 Fix CI on pnpm audit, by [@DefiCake](https://github.com/DefiCake) (See [#217](#217)) - Add FTI interface, by [@DefiCake](https://github.com/DefiCake) (See [#151](#151)) - Improve granularity of blacklisting permissions for messages in FuelMessagePortal, by [@DefiCake](https://github.com/DefiCake) (See [#168](#168)) - Add comments to Hexens audit. Fix some other in-code commentary, by [@DefiCake](https://github.com/DefiCake) (See [#177](#177)) - Added FuelChainState devnet and testnet redeploy artifacts, by [@DefiCake](https://github.com/DefiCake) (See [#235](#235)) - Reconfigured testnet and devnet contracts, by [@DefiCake](https://github.com/DefiCake) (See [#236](#236)) - Update testnet and devnet contracts, by [@DefiCake](https://github.com/DefiCake) (See [#185](#185)) - Removed unused and vulnerable npm dependencies, by [@DefiCake](https://github.com/DefiCake) (See [#212](#212)) ## @fuel-bridge/test-utils@0.6.0 ### Minor Changes - Improve message relay utils, by [@DefiCake](https://github.com/DefiCake) (See [#275](#275)) - Adapted deployments for a full e2e environment, and minor util adaptions to anvil quirks, by [@DefiCake](https://github.com/DefiCake) (See [#229](#229)) - Upgrade all dependencies to fuel-core 0.27, by [@SwayStar123](https://github.com/SwayStar123) (See [#201](#201)) - Bump ts-sdk to 0.94.4, by [@DefiCake](https://github.com/DefiCake) (See [#277](#277)) - 🐞 Fix depositToken naming, by [@DefiCake](https://github.com/DefiCake) (See [#273](#273)) - Architecture revamp featuring single asset issuer on L2, by [@DefiCake](https://github.com/DefiCake) (See [#150](#150)) - Bump all packages to adhere to fuel-core 0.26, forc 0.56, fuel-rs 0.60, fuel-ts 0.85, by [@DefiCake](https://github.com/DefiCake) (See [#180](#180)) - Add relay deposit script, by [@DefiCake](https://github.com/DefiCake) (See [#266](#266)) - add disable initializer in erc20 v4 gateway, by [@viraj124](https://github.com/viraj124) (See [#261](#261)) - Upgraded fuel dependencies to fuel-core 0.33, by [@DefiCake](https://github.com/DefiCake) (See [#237](#237)) - Implement SRC-7 and SRC-20, by [@DefiCake](https://github.com/DefiCake) (See [#240](#240)) - Added upgradability to bridge contracts, by [@DefiCake](https://github.com/DefiCake) (See [#164](#164)) - Add typegen for fuel ts sdk and a deploy script for the bridge. Bump fuel-core to v0.31.0, by [@DefiCake](https://github.com/DefiCake) (See [#222](#222)) - Upgraded ts-sdk to 0.94.3, by [@DefiCake](https://github.com/DefiCake) (See [#271](#271)) - Update fuel-core to v0.26.0 and all sdk dependencies needed to track it, by [@DefiCake](https://github.com/DefiCake) (See [#161](#161)) ### Patch Changes - Increase test coverage, by [@DefiCake](https://github.com/DefiCake) (See [#226](#226)) - Update documentation, by [@DefiCake](https://github.com/DefiCake) (See [#197](#197)) - Use ZeroBytes32 for witnesses at relayCommonMessage.ts, by [@DefiCake](https://github.com/DefiCake) (See [#193](#193)) - 🐞 Fix CI on pnpm audit, by [@DefiCake](https://github.com/DefiCake) (See [#217](#217)) - Removed unused and vulnerable npm dependencies, by [@DefiCake](https://github.com/DefiCake) (See [#212](#212)) - Bump forc and ts version, by [@DefiCake](https://github.com/DefiCake) (See [#162](#162)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dependencies with the current target of testnet
NOTICE: due to the enforced requirement to use the new v1 encoding, the predicate has been substantially modified, as the calldata that gets passed to the sway bridge now follows a different pattern.
During this process and according to different audits that have signalled that ETH values on the payload could get potentially stuck on the sway bridge, I have decided to go beyond and completely remove any fund forwarding of the predicate to the bridge. If it is going to get stuck anyway, we may as well simplify its logic so that the funds do stay at the predicate, not at the bridge. This issue has been cataloged as informational / low risk because in order to happen, the solidity contracts need to be flawed themselves.