-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove H160 from config and use Bytes20 #469
Labels
fuel-core
fuel-relayer
good first issue
Good for newcomers
tech-debt
The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Comments
xgreenx
added
the
tech-debt
The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
label
Jan 31, 2023
9 tasks
5 tasks
xgreenx
added a commit
that referenced
this issue
Aug 27, 2024
## Linked Issues/PRs #469 ## Description Replace H160 in config and cli options of relayer by Bytes20. This might cause a bit of performance impact as it's needed to transform them to `H160` to interact with `ethers_core` dependency. (This PR follows #1951) ## Checklist - [x] Breaking changes are clearly marked as such in the PR description and changelog - [x] New behavior is reflected in tests - [x] [The specification](https://github.com/FuelLabs/fuel-specs/) matches the implemented behavior (link update PR if changes are needed) ### Before requesting review - [x] I have reviewed the code myself - [x] I have created follow-up issues caused by this PR and linked them here --------- Co-authored-by: green <xgreenx9999@gmail.com>
GoldenPath1109
added a commit
to GoldenPath1109/fuel-core
that referenced
this issue
Sep 7, 2024
## Linked Issues/PRs FuelLabs/fuel-core#469 ## Description Replace H160 in config and cli options of relayer by Bytes20. This might cause a bit of performance impact as it's needed to transform them to `H160` to interact with `ethers_core` dependency. (This PR follows FuelLabs/fuel-core#1951) ## Checklist - [x] Breaking changes are clearly marked as such in the PR description and changelog - [x] New behavior is reflected in tests - [x] [The specification](https://github.com/FuelLabs/fuel-specs/) matches the implemented behavior (link update PR if changes are needed) ### Before requesting review - [x] I have reviewed the code myself - [x] I have created follow-up issues caused by this PR and linked them here --------- Co-authored-by: green <xgreenx9999@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fuel-core
fuel-relayer
good first issue
Good for newcomers
tech-debt
The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
This is low priority task and consists of removing fuel-relayer
H160
config field and cli options and replacing them with nativeBytes20
alternatives.Bytes20
will be introduces infuel-types
versionv0.5.2
or higher.The text was updated successfully, but these errors were encountered: