Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.20.7 *do not merge* #1425

Closed
wants to merge 3 commits into from
Closed

Release/0.20.7 *do not merge* #1425

wants to merge 3 commits into from

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Oct 16, 2023

This contains the planned hotfixes for beta4, this PR isn't intended to be merged, but just to run a full CI pass on all the changes together.

includes:

#1422
#1423

xgreenx and others added 3 commits October 15, 2023 20:13
fixes: #1421

---------

Co-authored-by: xgreenx <xgreenx9999@gmail.com>
…reasing (#1423)

Closes #1384

After debugging the issue with transaction broadcasting in the Beta 4
network, I can confirm that it is related to the gossipsub reputation.

At some point, no one sends transactions to the authority node. When I
manually restart one sentry node, this node starts to send transactions
to the authority node. It sends transactions via gossiping and
publishing:
- Publishing: I send a transaction to sentry 1, which sends it to
authority.
- Gossiping: I send the transaction to sentry 0, it sends the
transaction to sentry 1, and it sends the transaction to authority.

But at some point, gossiping doesn't work while publishing still
works(Sentry 0 gossips transaction to Sentry 1, and Sentry 1 doesn't
gossip it to authority).

After some time, the publishing doesn't work either.

The gossipsub has two thresholds, one for gossiping and one for
publishing. We use these values:

<img width="652" alt="image"
src="https://github.com/FuelLabs/fuel-core/assets/18346821/bcb1585c-239b-4cf9-9fae-c9376b958201">

So, the described behavior aligns with authority reputation decreasing.
I don't know the reason why it happens(maybe decay), but adding all
reserved peers to explicit peers should solve the problem.
@xgreenx
Copy link
Collaborator

xgreenx commented Oct 17, 2023

It is released https://github.com/FuelLabs/fuel-core/releases/tag/v0.20.7, so we can close the PR=)

@xgreenx xgreenx closed this Oct 17, 2023
@5641665
Copy link

5641665 commented Nov 7, 2023

This problem is very significant, and we hope to close it down as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants