feat: include Transaction events in topic0 filter for download_logs #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefiCake
force-pushed
the
deficake/1979-download-logs-fti
branch
from
8d25555
to
6f4fe77
Compare
xgreenx
reviewed
Jun 18, 2024
| @@ -6,6 +6,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| - [#1980](https://github.com/FuelLabs/fuel-core/pull/1980): Add `Transaction` to relayer 's event filter | |||
There was a problem hiding this comment.
Does L1 testnet/devnet contracts support FTI already? If yes, then we need additional code to handle this problem=)
There was a problem hiding this comment.
No, the current contract deployments do not support FTI.
I am currently developing it and the integration tests fail because this code is missing.
I thought FTI was already supported by fuel-core? In fact, after doing these changes, I have been able to trigger transactions through the relayer, locally.
There was a problem hiding this comment.
Yeah, we thought that we implemented everything=D But it seems we forgot to update the request to Ethereum RPC)))
Okay, if any network has no support for FTI, then we don't need any additional code.
Voxelot
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1979
[Short description of the changes.]
Checklist
Before requesting review