fix: format units according to asset decimals + unknown asset #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success0 tests passing in 0 suite. Report generated by 🧪jest coverage report action from 1170dbf |
FE-31 Unknown assets should have units 0 by default
When working with custom assets that we don't have the metadata, is not a good thing to format by default with 9 decimals, to avoid this let's fix default units for unknown assets to 0. This should affect all places that have asset balance. |
luizstacio
requested changes
Nov 15, 2023
There was a problem hiding this comment.
The amount format is great, but it should not have any decimal... as a decimal .0 for integer means one more 0 that don't exist.
Account example: https://fuel-explorer-j0r8fpcif-fuel-labs.vercel.app/account/fuel18e7amfxs60urq7h97xhdsa3rnykpcn0valkxsjfkjcrh2xqmyvpq4ay9jn It should be showing 1,052,399,877 only.
luizstacio
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FE-31
this PR address fully the format of amounts being showed across the explorer. will format to assets decimal config OR format the raw amount if it’s a unknown asset (unknown asset decimals)
fuels/assets@0.1.3to get new asset utils functions