Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust tabs across app & remove contract unused tabs #116

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Conversation

pedronauck
Copy link
Contributor

@pedronauck pedronauck commented Nov 14, 2023

⭐ Closes FE-28
⭐ Closes FE-30
⭐ Closes FE-46
⭐ Closes FE-41

Copy link

linear bot commented Nov 14, 2023

FE-28 Change Tabs design on all pages to follow the contracts page layout

Move all pages with tabs from this:

Screenshot 2023-11-09 at 2.47.54 PM.png

To this:

Screenshot 2023-11-09 at 2.49.06 PM.png

FE-30 Remove unused features

Currently, the Explorer does not have some features on the screen. For now, we should remove them;

Contract Page
- Transaction tab;
- Mint tab;
- Advanced toggle;

FE-46 Fix: way of importing ui-primitives css

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from e9ffad0

Copy link

linear bot commented Nov 14, 2023

Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tabs should look like the following but I don't see the changes they look like buttons yet.
Screenshot 2023-11-09 at 2 49 06 PM

@pedronauck
Copy link
Contributor Author

The tabs should look like the following but I don't see the changes they look like buttons yet. Screenshot 2023-11-09 at 2 49 06 PM

I just followed what we have on Figma dude

@LuizAsFight
Copy link
Contributor

we talked to use button style in our sync meeting... but I also prefer the contract tab style

cc @pedronauck @luizstacio

Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found two more things here:

  1. Minor one is the margin between the line in the top and the tabs.
Screenshot 2023-11-15 at 6 09 48 PM
  1. On this version if you navigate to a tab and click to return on the browser, the content changes but the tabs not. Testing on the master version this issue not exists.

@pedronauck pedronauck merged commit 9351a8b into main Nov 15, 2023
7 checks passed
@pedronauck pedronauck deleted the pn/fe-28 branch November 15, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants