feat: add cursors where applicable #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FE-40 Add pointer cursor on buttons and links
The pagination component should show a pointer cursor on the prev and next buttons when they are they are enabled. This should respect the disabled props. The task should impact:
|
LuizAsFight
requested changes
Nov 29, 2023
| > | ||
| {isLoading ? ( | ||
| <Spinner color="current" size={getIconSize(size, iconSize)} /> | ||
| ) : ( | ||
| <Icon | ||
| className={cx(iconClassName, 'cursor-pointer')} | ||
| className={iconClassName} |
There was a problem hiding this comment.
you need to keep the cx( here right?
Suggested change
| className={iconClassName} | |
| className={cx(iconClassName)} |
There was a problem hiding this comment.
no I don't think we need cx here. If you look here iconClassName was not initially wrapped with cx. I believe cx is used when we want to add classes to an existing class.
LuizAsFight
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes FE-40