chore: update beta-5 #139
Merged
chore: update beta-5 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizstacio
requested changes
Jan 10, 2024
| @@ -4,7 +4,7 @@ FROM node:20-slim AS base | |||
|
|
|||
| # Expose the ENVs to the env of the container | |||
| ENV PORT="${PORT}" | |||
| ENV FUEL_PROVIDER_URL="${FUEL_PROVIDER_URL}" | |||
| ENV FUEL_PROVIDER_BETA5="${FUEL_PROVIDER_BETA5}" | |||
There was a problem hiding this comment.
Why we change the name of the provider here?
There was a problem hiding this comment.
FUEL_PROVIDER_URL was better IMO to avoid needing to change later.
luizstacio
reviewed
Jan 10, 2024
Comment on lines
-141
to
-147
| regularEl={ | ||
| <> | ||
| Gas used: {formatZeroUnits(tx.gasUsed || '')} | ||
| <br /> | ||
| Gas limit: {formatZeroUnits(tx.gasLimit || '')} | ||
| </> | ||
| } |
There was a problem hiding this comment.
Gas limit is available for transaction of type Script, you can find it on the policies array and on the field scriptGasLimit.
LuizAsFight
requested changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.