Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connect wallet before confirm if not connected #170

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

luizstacio
Copy link
Member

On this PR;

  • Add a setting configuration object to pass data around overlay action this is required to pass the data at the time Dialog should close check happens.
  • This solves the issue where user is required to confirm TX but ETH Wallet is not connected. Creating the flow of asking first to connect, and them keeping the user on the screen to finish the action.

@LuizAsFight LuizAsFight merged commit cbe4dae into main Feb 10, 2024
6 checks passed
@LuizAsFight LuizAsFight deleted the ls/fix/confirm-without-connected-wallet branch February 10, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants