Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Hero component #35

Merged
merged 5 commits into from
Sep 13, 2023
Merged

feat: add Hero component #35

merged 5 commits into from
Sep 13, 2023

Conversation

pedronauck
Copy link
Contributor

⭐ Closes FRO-461

@pedronauck pedronauck self-assigned this Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 13.46% 7/52
🔴 Branches 16.67% 2/12
🔴 Functions 10.53% 2/19
🔴 Lines 13.73% 7/51

Test suite run success

3 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 8e912ae

Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is huge, can we optimize a bit? 18MB...

@pedronauck
Copy link
Contributor Author

This image is huge, can we optimize a bit? 18MB...

it's been optimized internally by nextjs Image component

@pedronauck pedronauck merged commit 3141198 into main Sep 13, 2023
@pedronauck pedronauck deleted the pn/feat/hero branch September 13, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants